search

bmd-studio / stm32-for-vscode

STM32 extension for working with STM32 and CubeMX in VSCode
MIT License
207 stars 27 forks source link

Incorrect YAML formatting results in silent delete and rebuild of YAML file #116

Closed jnz86 closed 1 year ago

jnz86 commented 2 years ago

I've noticed that if you incorrectly format a YAML entry and build, that the entire file seems to be deleted and rebuilt using the original makefile from the MX system. The issue is this happens silently, and the make process is continued as usual.

If the "example" entry below has an additional " at the end, this will result in all YAML file changes being removed and rebuilt from original make. 

IncludeDirectories: 
  - "Core/**"
  - "Drivers/**"
  - "../../../../example/**""
  - "../../../../notice/the/extra/double/quote/above/"

If a warning and fixme type of halt can not be shown, is it possible to at least inform the user via a toast that YAML FILE ERROR, REBUILT FROM MAKEFILE" or something like that be shown to the user? It took me quite a bit of fiddling to figure out what was happening without notifications.

Thanks!

JohannesRgnr commented 2 years ago

I had a similar issue today. While editing some source files entries, the YAML file got back to default settings without warning.

jortbmd commented 2 years ago

Thanks for opening up this issue. I will integrate this in a next release.

jortbmd commented 1 year ago

This issues has been fixed in the current release (3.2.3). If you find any more issues concerning this feel free to re-open the issue or create a new one.