search

bmeaut / grainautline

GrainAutLine: image processing for geology and material sciences
GNU General Public License v3.0
0 stars 2 forks source link

MGS C++ warnings #100

Closed szotsaki closed 4 years ago

szotsaki commented 8 years ago

Please, fix the following C++ warnings generated by cppcheck:

[MarbleCommon/MGS/mgsmethods.h:42]: (performance) Function parameter 'fileName' should be passed by reference.
[MarbleCommon/MGS/mgsmethods.h:43]: (performance) Function parameter 'fileName' should be passed by reference.
[MarbleCommon/MGS/mgs.cpp:21]: (performance) Function parameter 'fileName' should be passed by reference.
[MarbleCommon/MGS/mgsmethods.cpp:94]: (performance) Function parameter 'fileName' should be passed by reference.
[MarbleCommon/MGS/mgsmethods.cpp:110]: (performance) Function parameter 'fileName' should be passed by reference.

Additionally, the following warning exists for Sandbox:

[SandboxAnna/SandboxAnna/main.cpp:49] -> [SandboxAnna/SandboxAnna/main.cpp:51]: (error) Iterator 'it' used after element has been erased.