Closed szotsaki closed 8 years ago
Warnings fixed. Unused functions preserved for later use, as we are developing a framework for long term use. (And sometimes we implement more than what is needed that time.)
New batch of warnings:
[MarbleCommon/BlobContainer.cpp:22]: (warning) Member variable 'BlobContainer::defaultFactory' is not initialized in the constructor.
[MarbleCommon/BlobsAndCurves/Blob2.h:274]: (style) Unused private function: 'Blob2SortedBuilder::GetBuilderFromRect'
[MarbleCommon/ColorChooser.cpp:34]: (style) The scope of the variable 'iI' can be reduced.
[MarbleCommon/ColorChooser.cpp:35]: (style) The scope of the variable 'fI' can be reduced.
[MarbleCommon/ColorChooser.cpp:35]: (style) The scope of the variable 'fF' can be reduced.
[MarbleCommon/ColorChooser.cpp:35]: (style) The scope of the variable 'p' can be reduced.
[MarbleCommon/ColorChooser.cpp:35]: (style) The scope of the variable 'q' can be reduced.
[MarbleCommon/ColorChooser.cpp:35]: (style) The scope of the variable 't' can be reduced.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.cpp:13]: (warning) Member variable 'SuperBlobContainer::lastChanged' is not initialized in the constructor.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.h:40]: (performance) Variable 'neighbourhoodVector' is assigned in constructor body. Consider performing initialization in initialization list.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.cpp:15]: (performance) Variable 'superBlobIndices' is assigned in constructor body. Consider performing initialization in initialization list.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.cpp:22]: (performance) Variable 'neighbourhood' is assigned in constructor body. Consider performing initialization in initialization list.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.cpp:28]: (performance) Variable 'neighbourhood' is assigned in constructor body. Consider performing initialization in initialization list.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.h:42]: (style) Class 'NeighbourhoodContainer' has a constructor with 1 argument that is not explicit.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.h:131]: (style) Class 'SuperBlobContainer' has a constructor with 1 argument that is not explicit.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.h:133]: (style) Class 'SuperBlobContainer' has a constructor with 1 argument that is not explicit.
[MarbleCommon/MinCutFinder/BFS.h:8]: (information) The code 'class WIN_DLL_DECLSPEC BFS :' is not handled. You can use -I or --include to add handling of this code.
[SandboxKristof/SandboxKristof/main.cpp:84]: (style) The scope of the variable 'sum' can be reduced.
[SandboxKristof/SandboxKristof/main.cpp:86]: (style) The scope of the variable 'curveLength' can be reduced.
[TestMarbleCommon/TestBlob.cpp:16] -> [TestMarbleCommon/TestBlob.cpp:17]: (performance) Variable 'area' is reassigned a value before the old one has been used.
Current status:
[MarbleCommon/ColorChooser.cpp:34]: (style) The scope of the variable 'iI' can be reduced.
[MarbleCommon/ColorChooser.cpp:35]: (style) The scope of the variable 'fI' can be reduced.
[MarbleCommon/ColorChooser.cpp:35]: (style) The scope of the variable 'fF' can be reduced.
[MarbleCommon/ColorChooser.cpp:35]: (style) The scope of the variable 'p' can be reduced.
[MarbleCommon/ColorChooser.cpp:35]: (style) The scope of the variable 'q' can be reduced.
[MarbleCommon/ColorChooser.cpp:35]: (style) The scope of the variable 't' can be reduced.
[MarbleCommon/BlobsAndCurves/Blob2.h:274]: (style) Unused private function: 'Blob2SortedBuilder::GetBuilderFromRect'
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.cpp:13]: (warning) Member variable 'SuperBlobContainer::lastChanged' is not initialized in the constructor.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.h:40]: (performance) Variable 'neighbourhoodVector' is assigned in constructor body. Consider performing initialization in initialization list.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.cpp:15]: (performance) Variable 'superBlobIndices' is assigned in constructor body. Consider performing initialization in initialization list.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.cpp:22]: (performance) Variable 'neighbourhood' is assigned in constructor body. Consider performing initialization in initialization list.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.cpp:28]: (performance) Variable 'neighbourhood' is assigned in constructor body. Consider performing initialization in initialization list.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.h:42]: (style) Class 'NeighbourhoodContainer' has a constructor with 1 argument that is not explicit.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.h:131]: (style) Class 'SuperBlobContainer' has a constructor with 1 argument that is not explicit.
[MarbleCommon/BlobsAndCurves/SuperBlobContainer.h:133]: (style) Class 'SuperBlobContainer' has a constructor with 1 argument that is not explicit.
[MarbleCommon/MinCutFinder/BFS.h:8]: (information) The code 'class BFS :' is not handled. You can use -I or --include to add handling of this code.
[SandboxKristof/SandboxKristof/main.cpp:84]: (style) The scope of the variable 'sum' can be reduced.
[SandboxKristof/SandboxKristof/main.cpp:86]: (style) The scope of the variable 'curveLength' can be reduced.
[TestMarbleCommon/TestBlob.cpp:16] -> [TestMarbleCommon/TestBlob.cpp:17]: (performance) Variable 'area' is reassigned a value before the old one has been used.
Fixed. Some (SuperBlobContainer) moved to Adam Budai. TestMarbleCommon is an old, MSCV based test project. Content will be moved to the Qt environment later.
cppcheck gave the following warnings:
And the following functions are unused (maybe these are required anyhow):