Closed szotsaki closed 8 years ago
Current cppcheck
warnings:
[MarbleCommon/ActiveContours/StaticSnake.h:33]: (style) Class 'StaticSnake' has a constructor with 1 argument that is not explicit.
[MarbleCommon/ActiveContours/StaticSnake.h:39]: (style) Class 'StaticSnake' has a constructor with 1 argument that is not explicit.
[MarbleCommon/ActiveContours/DynamicSnakeInterface.h:14]: (style) Class 'DynamicSnakeInterface' has a constructor with 1 argument that is not explicit.
[MarbleCommon/ActiveContours/GVFForce.h:35]: (style) Class 'GVFForce' has a constructor with 1 argument that is not explicit.
Current GCC warnings:
In file included from ../../MarbleCommon/ActiveContours/GVFForce.cpp:1:0:
../../MarbleCommon/ActiveContours/GVFForce.h: In constructor 'GVFForce::GVFForce(const cv::String&)':
../../MarbleCommon/ActiveContours/GVFForce.h:121:17: warning: 'GVFForce::edgeMapType' will be initialized after [-Wreorder]
EdgeMapType edgeMapType;
^
../../MarbleCommon/ActiveContours/GVFForce.h:111:11: warning: 'float GVFForce::mu' [-Wreorder]
float mu;
^
../../MarbleCommon/ActiveContours/GVFForce.h:35:5: warning: when initialized here [-Wreorder]
GVFForce(const cv::String& fileName)
^
../../MarbleCommon/ActiveContours/GVFForce.h:157:11: warning: 'GVFForce::iterThreshold' will be initialized after [-Wreorder]
float iterThreshold;
^
../../MarbleCommon/ActiveContours/GVFForce.h:146:14: warning: 'unsigned int GVFForce::iterCnt' [-Wreorder]
unsigned iterCnt;
^
../../MarbleCommon/ActiveContours/GVFForce.h:35:5: warning: when initialized here [-Wreorder]
GVFForce(const cv::String& fileName)
^
../../MarbleCommon/ActiveContours/GVFForce.cpp: In member function 'void GVFForce::calculateEdgeMap()':
../../MarbleCommon/ActiveContours/GVFForce.cpp:124:12: warning: enumeration value 'NOT_DEFINED' not handled in switch [-Wswitch-enum]
switch (edgeMapType)
^
For the first ones, just reorder the initialisation order in the constructor to match the declaration order in the body.
Please, fix the following C++ warnings generated by
cppcheck
:Additionally, the following C++ warnings exist generated by GCC: