Open muhammad-naderi opened 8 years ago
muhammad-naderi
commented
8 years ago also in the 2d scrolling mode, child node(s) do not go a step forward (in horizontal axis) say in LtR languages they behave like this : -Parent --child --child ---grandchild ---grandchild ----great-grandchild -----great-great-grandchild --child
but in RtL languages they remain same:
-Parent -child -child -grandchild -grandchild -great-grandchild -great-great-grandchild -child
bmelnychuk
commented
8 years ago Unfortunately, I haven't try it for RtL languages.. But I will take a look on it, this week
muhammad-naderi
commented
8 years ago hey,
sorry to ask, have you made any progress on this bug ?
cvelasco88
commented
8 years ago No, sorry. I didn't work on that :s
El 17/11/2015 8:32, Muhammad Naderi notifications@github.com escribió:
hey,
sorry to ask, have you made any progress on this bug ?
— Reply to this email directly or view it on GitHub.
bmelnychuk
commented
8 years ago Actually I tried that, I tried to force right to left in developer options and rtl language as well, the app behaved exactly the same. I did not found any issues with tree itself (Nexus 5, Android 5/6). I think this can fixed per ViewHolder implementation As I remember there were some changes in android related to rtl starting from api 17, What device did you use?
muhammad-naderi
commented
8 years ago devices I use are: samsung galaxy note 3 lollipop samsung galaxy tab 4 Kitkat samsng galaxy tab s lollipop samsung galaxy a 7 lollipop
the main problem is in rtl mode, while the 2d mode is on, if you swipe from right to left on the screen, the tree view will scroll to right indefinitely.
muhammad-naderi
commented
8 years ago this also happens in your test application, with force rtl in developer options
muhammad-naderi
commented
8 years ago honestly i'm not that much familiar with github, but the problem is in Styles
you need to add this line as well:
<item name="android:paddingStart">20dp</item>and since the Start-End (equivalent to Left-Right) properties have been introduced since api level 17, you need to create a v17/styles.xml override.
android studio does the job by a single alt-enter ;)
cvelasco88
commented
8 years ago Ok, thanks for tell me about. If I can I will check that for my app for the next version :)
El 17/11/2015 13:36, Muhammad Naderi notifications@github.com escribió:
devices I use are: samsung galaxy note 3 lollipop samsung galaxy tab 4 Kitkat samsng galaxy tab s lollipop samsung galaxy a 7 lollipop
the main problem is in rtl mode, while the 2d mode is on, if you swipe from right to left on the screen, the tree view will scroll to right indefinitely.
— Reply to this email directly or view it on GitHub.
First, I would like to thank you for such a valuable work ! ... well down !
second, there is a problem with RtL (Right to Left) in the library which is on devices with RTL language, with the 2d scrolling mode, tree goes outside of the screen if you scroll to left !