search

bmericc / domainhunter

A Simple domain monitoring application
http://www.domainhunter.org.tr
GNU General Public License v3.0
10 stars 3 forks source link

MVC pattern proposal #1

Open plumthedev opened 4 years ago

plumthedev commented 4 years ago

Hey there!

Your project is great, I'm impressed about it but last commit is 5 years old and whole project do not have any design pattern. I want propose to you rewriting project to Model View Controller design pattern and follow the PSR rules.

What do you think?

bmericc commented 4 years ago

Hello

I don't have enough time to rewrite. If you want to rewrite it as open-source, we can publish it as Domain Hunter.

Bahri Meriç CANLI

www.bahri.info

On Mon, Nov 11, 2019 at 11:51 PM Kacper Pruszynski notifications@github.com wrote:

Hey there!

Your project is great, I'm impressed about it but last commit is 5 years old and whole project do not have any design pattern. I want propose to you rewriting project to Model View Controller design pattern and follow the PSR rules.

What do you think?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bmericc/domainhunter/issues/1?email_source=notifications&email_token=AAAEBKFUGR3GD3NSHBCHVJTQTHAVHA5CNFSM4JL2UTSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYQSW5Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEBKB4OUP2MOMKRSS7KYTQTHAVHANCNFSM4JL2UTSA .

plumthedev commented 4 years ago

It will happen 😃 Thanks for permission!

plumthedev commented 4 years ago

@bmericc it good news! First approach for MVC started here!

bmericc commented 4 years ago

Thanks, I will follow your repository

Bahri Meriç CANLI

www.bahri.info

On Wed, Nov 13, 2019 at 2:59 AM Kacper Pruszynski notifications@github.com wrote:

@bmericc https://github.com/bmericc it good news! First approach for MVC started here https://github.com/plumthedev/domainhunter!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bmericc/domainhunter/issues/1?email_source=notifications&email_token=AAAEBKDO7F4RHIE4OVJTBPLQTM7OFA5CNFSM4JL2UTSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED4MCGY#issuecomment-553173275, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEBKAEVEGFMNSIJG3OKW3QTM7OFANCNFSM4JL2UTSA .