`Smart Select` can't select content without brackets

[kanlukasz]

Describe the bug Smart Select cannot select content without parentheses The first expansion marks first bracket (what for ??), and then second expansion select all the content, including the brackets. In the end, it is impossible to mark the whole without brackets

To Reproduce

<?php

if ($_POST) {
  print 'Hello post data';
  print 'Hello post data';
  print 'Hello post data';
}

Screenshot - Current behavior

Screenshot - Expected behavior

Platform and version

Version: 1.49.1 (system setup)
Commit: 58bb7b2331731bf72587010e943852e13e6fd3cf
Date: 2020-09-16T23:27:51.792Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19041

[bmewburn]

Not sure about this one. The reason the opening brace is selected first is because the cursor is next to it and this is deemed more important than whitespace so it becomes the terminal node in the syntax tree and the ranges computed from there. You're right that it differs from the default vscode implementation but it is still possible to select the block without the braces if started within the block.

Comparing to another language, Typescript, ts server shows similar behaviour to intelephense when the cursor is adjacent to opening brace.