Go to definition open the stubs files.

kallookoo commented 1 month ago

Describe the bug Go to definition open the stubs files.

To Reproduce Enable the WordPress stub, use "Go to definition" and open the wordpress-stubs.php file that includes the extension.

Expected behavior Show "No definition found", as it was done in version <= 1.10

Screenshots If applicable, add screenshots to help explain your problem.

Platform and version Macos Sonoma, VS Code 1.92.1

bmewburn commented 1 month ago

This is as designed. There was an issue requesting this change. It was also done to avoid issues with displaying type hierarchy. Is there a specific reason why it is a problem showing the stubs?

kallookoo commented 1 month ago

I understand what you are saying, but from my point of view it does not make sense to show the stubs for the following reasons:

It is necessary to exclude from PHPCS the stubs in all projects.
In case the folder in the workspace is from a WordPress installation, the definitions are duplicated.
From my point of view the definitions are to see your complete code or to see where it is inside the project. By default the PHPDoc is shown when hovering over it and opening a stubs doesn't make sense.

But come on, it's my opinion and I'll have to adapt if it sticks.

bmewburn / vscode-intelephense

Go to definition open the stubs files. #2989