bmeyers / SolarForecasting

8 stars 3 forks source link

General forecaster class #7

Open bmeyers opened 6 years ago

bmeyers commented 6 years ago

We should have a general forecaster class in core.utilities that all specific forecasters subclass.

bmeyers commented 6 years ago

Methods:

Attributes:

juliohm commented 6 years ago

Shouldn't plot_test() and calc_mse() be standalone functions?

bmeyers commented 6 years ago

I think they should be methods on the base class. They could reference standalone function if we want, but the class should have those methods.

juliohm commented 6 years ago

Sounds good, whatever works best for you :blush: It is usually not a good idea in larger projects to break encapsulation with external standalone functions though. This is one of the main limitations of object-oriented programming: the continuous attempt to organize code inside classes and the struggle to decide what should be part or not of the class interface.