bmihaljevic / bnclassify

Learning Discrete Bayesian Network Classifiers from Data
18 stars 10 forks source link

Fix cran error due to change underlying `sample()` #30

Open bmihaljevic opened 5 years ago

bmihaljevic commented 5 years ago

lease see the problems shown on https://cran.r-project.org/web/checks/check_results_bnclassify.html.

The check problems with current R-devel are from

 • The default method for generating from a discrete uniform
   distribution (used in sample(), for instance) has been changed.
   ...
   The previous method can be requested using RNGkind() or
   RNGversion() if necessary for reproduction of old results.

To make your package successfully pass the checks for current R-devel and R-release you may find it most convenient to insert

suppressWarnings(RNGversion("3.5.0"))

before calling set.seed() in your example, vignette and test code (where the difference in RNG sample kinds matters, of course).

Note that this ensures using the (old) non-uniform "Rounding" sampler for all 3.x versions of R, and does not add an R version dependency. Note also that the new "Rejection" sampler which R will use from 3.6.0 onwards by default is definitely preferable over the old one, so that the above should really only be used as a temporary measure for reproduction of the previous behavior (and the run time tests relying on it).

Please correct before 2019-03-20 to safely retain your package on CRAN.