bmild / nerf

Code release for NeRF (Neural Radiance Fields)
http://tancik.com/nerf
MIT License
9.6k stars 1.34k forks source link

Question about positional encoding #65

Closed luyangzhu closed 3 years ago

luyangzhu commented 3 years ago

Thank you for your nice work and impressive results!

I have a question about the positional encoding. In the equation (4) of the paper, input is multiplied by pi before sent into sine and cosine function. But in the run_nerf_helper.py, the class Embedder do not times pi before applying sine and cosine. Did I miss something or the pi does not affect results that much?

kwea123 commented 3 years ago

duplicate of #12