search

bminer / node-blade

Blade - HTML Template Compiler, inspired by Jade & Haml
Other
320 stars 28 forks source link

Breaks after upgrading to Meteor 0.6.5 #188

Closed jonasferagen closed 10 years ago

jonasferagen commented 11 years ago

'sourcePath' option must be supplied to addJavaScript. Consider passing inputPath. (compiling client/views/main.blade)

at Object..extend.build..each.compileStep.addJavaScript (/home/chroz/.meteor/tools/4010e5731d/tools/packages.js:418:19) at Object._.extend.initFromPackageDir.Package.register_extension.self.legacyExtensionHandlers. (anonymous function).api.add_resource (/home/chroz/.meteor/tools/4010e5731d/tools/packages.js:1248:29) at package.js:150:19 at /home/chroz/.meteorite/packages/blade/bminer/meteor-blade/28a9f9bf121c3410ab70138ba39862468bfe836b/.npm/package/node_modules/blade/lib/blade.js:61:4 at Compiler.compile (/home/chroz/.meteorite/packages/blade/bminer/meteor-blade/28a9f9bf121c3410ab70138ba39862468bfe836b/.npm/package/node_modules/blade/lib/compiler.js:184:2) at compile (/home/chroz/.meteorite/packages/blade/bminer/meteor-blade/28a9f9bf121c3410ab70138ba39862468bfe836b/.npm/package/node_modules/blade/lib/blade.js:57:12) at Object.compileFile (/home/chroz/.meteorite/packages/blade/bminer/meteor-blade/28a9f9bf121c3410ab70138ba39862468bfe836b/.npm/package/nodemodules/blade/lib/blade.js:82:3) at package.js:40:9 at .extend.initFromPackageDir.Package.register_extension.self.legacyExtensionHandlers. (anonymous function) (/home/chroz/.meteor/tools/4010e5731d/tools/packages.js:1289:13)

bminer commented 11 years ago

Ha, yes... this is why I haven't touched this project in a while. The Meteor team continues to make breaking changes. No problem... I will take a look at this when I return to my home country next week. If you can provide a patch in the meantime, that would be much appreciated!

bminer commented 11 years ago

Related issue: https://github.com/bminer/meteor-blade/issues/5

jonasferagen commented 11 years ago

Ah, yeah sorry this shouldve been in meteor-blade. Thanks for a great package btw :)

zakdances commented 11 years ago

Do both https://github.com/bminer/node-blade and https://github.com/bminer/meteor-blade need to be altered to fix this bug? Or just one of them? Where's the best place to starting look to fix this?

bminer commented 11 years ago

@zakdances - Good question. Probably only meteor-blade needs to be fixed. Hard to tell into I delve into it a bit.

zakdances commented 11 years ago

Is the solution still proving to be allusive? I haven't looked through the source code yet...were you able to find some time to do so?

jonasferagen commented 11 years ago

I looked into it briefly..Can't say I was left much wiser. Only thing I found was the line - bundle.add_resource in meteor-blade/package.js -

In meteor/tools/packages.js - line 1212 - in add_resource - here, compileStep.addJavaScript is called, without the (now?) mandatory sourcePath argument - this causes problems. Which is weird, since this is a meteor internal.. and I guess it wouldve broken lots of other packages as well, but I haven't seen any references to similar errors anywhere.

The register_extension API is deprecated.. although replaced with some transitory one. I can see it's frustrating developing this stuff. I'm pretty new to node.js, and especially Meteor. Sorry for not being of more assistance.

My blade templates have some inline javascript, and associated coffee files for registering events and such. Dunno if that may have something to do with it?

2013/8/23 zakdances notifications@github.com

Is the solution still proving to be allusive? I haven't looked through the source code yet...were you able to find some time to do so?

— Reply to this email directly or view it on GitHubhttps://github.com/bminer/node-blade/issues/188#issuecomment-23144885 .

vraptor75011 commented 11 years ago

Related issue : https://github.com/bminer/meteor-blade/pull/7

rantav commented 11 years ago

Looking forward to working with 0.6.5.* as well... :+1:

bminer commented 10 years ago

Sorry, guys. Just wanted to provide an update. It's looking like I won't be investing much time into Blade + Meteor support until Meteor 1.0. I am waiting for the Meteor APIs to freeze up a bit more (they seem to change too often).

Fortunately, there seems to be a promising pull request (https://github.com/bminer/meteor-blade/pull/7) that fixes support for Meteor 0.6.5.1. I'm hoping to get some more feedback from everyone using the new fork to see if it's safe to merge the PR.

Anyway, since I am trying to keep Blade separate from the Blade + Meteor project, I'm closing this issue for now. Please feel free to post on the related meteor-blade PR: https://github.com/bminer/meteor-blade/pull/7

Thanks!