search

bminer / node-blade

Blade - HTML Template Compiler, inspired by Jade & Haml
Other
320 stars 28 forks source link

Locked down 'pegjs' and 'uglify-js' dependencies. #210

Closed CodeLenny closed 7 years ago

CodeLenny commented 7 years ago

Hey Blake,

I noticed uglify-js v3 was just released, which includes breaking changes. I didn't look through the changes, but they broke the middleware serving /blade/blade.js, as well as tmpl.toString(), which now returns undefined:

blade._cachedViews["IDE.blade"]=undefined;var e=blade._cb["IDE.blade"];e&&e(null,".",[],false);

While creating the fork to specify the uglify-js version number, I found that pegjs removed the --track-line-and-column option in version 0.8.0 (4th item in the big changes), so I locked pegjs down as well.

I converted your version numbers from greater-than >=2.2.3 to caret syntax (^2.2.3). I can convert them back to version ranges if they were specified with greater-than for a reason, or if you just prefer that syntax.

Thanks, Ryan

bminer commented 7 years ago

Thanks!

CodeLenny commented 7 years ago

@bminer Thank you for merging so quickly!