search

bmino / binance-triangle-arbitrage

Detect in-market cryptocurrency arbitrage
MIT License
1.07k stars 336 forks source link

Add containerization #107

Closed gabriel-milan closed 3 years ago

gabriel-milan commented 4 years ago

First of all, thanks for your work. Your bot seems to be well implemented. Haven't been able to test it yet, unfortunately.

One thing I've missed here was deploying it by using containers, since it would help to ease the deployment itself and to scale it, if necessary. Since that's a very simple thing to do, I've added code here in order to bring this feature and added instructions on the README file. Feel free to merge this or not.

Best wishes, Gabriel

bmino commented 4 years ago

Hey! Thank you for the appreciation and the PR!

I'm not sure how you would want to scale this app via docker particularly as it maintains an internal depth cache in memory? Personally I'm avoiding docker because of the overhead. We're really down to the milliseconds here

gabriel-milan commented 4 years ago

I'm not sure how you would want to scale this app via docker

I was thinking about easing the distribution of this bot (if you're on a RKE Cluster, for example). As Docker has very little overhead, I've tried that, but could really tell the difference on numbers. Howsoever, IMHO Docker distributions are nice things to have.

We're really down to the milliseconds here

Yeah, things seem pretty sensitive here. I've started my own open implementation using C++ and Python (I'm not really familiar with JS) but it's very early stage (few days old), I might study your implementation further, so I can improve mine.

the-love-guru commented 3 years ago

Nice work on dockerfying the bot.