search

bmino / binance-triangle-arbitrage

Detect in-market cryptocurrency arbitrage
MIT License
1.08k stars 340 forks source link

How to enable "read only" version with no MIN and no MAX? #60

Closed marsrobertson closed 5 years ago

marsrobertson commented 5 years ago 
Error: An available balance of 0.015 BTC is required to satisfy your INVESTMENT.MIN configuration
    at checkBalances (/Users/ms/Stuff/binance-triangle-arbitrage/src/main/Main.js:173:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)
Error: An available balance of 0.035 BTC is required to satisfy your INVESTMENT.MAX configuration
    at checkBalances (/Users/ms/Stuff/binance-triangle-arbitrage/src/main/Main.js:178:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)

I just don't have any coins on that exchange, would like to run the bot anyway. So far commented out the lines that are complaining: https://github.com/bmino/binance-triangle-arbitrage/blob/0dae169110d20133603331a0371c6647cb1b6e9e/src/main/Main.js#L170-L179

bmino commented 5 years ago

Great point. Perhaps those pre-runtime checks should only be executed if TRADING.ENABLED is true?

steveeakin commented 5 years ago

I like that.

I build in DEMO mode in my fork that somewhat accomplishes this.

On Sun, Jun 16, 2019, 6:01 PM Brandon notifications@github.com wrote:

Great point. Perhaps those pre-runtime checks should only be executed if TRADING.ENABLED is true?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bmino/binance-triangle-arbitrage/issues/60?email_source=notifications&email_token=ABBPN3SFPWOGJPLUN3UHHJLP22Z2XA5CNFSM4HYSDF7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZWCHY#issuecomment-502489375, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBPN3X5UEHDSZIYKNI66B3P22Z2XANCNFSM4HYSDF7A .

bmino commented 5 years ago

I've got those changes introduced in the develop branch for the next release :)

bmino commented 5 years ago

Please check out release 5.2.0 and verify this issue is resolved