search

bmir-radx / radx-data-dictionary-specification

A specification for CSV data dictionaries in the RADx data hub
BSD 2-Clause "Simplified" License
0 stars 2 forks source link

spaces in column names #7

Closed pwrose closed 1 year ago

pwrose commented 1 year ago

There are two dictionary columns with spaces:Missing Value Codes and CDE Reference. Spaces in column names require some extra quoting in some programming languages and database systems. It would be best practice to avoid spaces in column names. I suggest to use Missing_Value_Codes and CDE_Reference to avoid those issues.

matthewhorridge commented 1 year ago

I wish I'd done that (although I'm not a fan of snake case). Some of the other DCCs have already generated data dictionaries and uploaded them so I'd rather not change this, if it's not critical. Happy for more conversation on this.

pwrose commented 1 year ago

Actually, I only meant removing the space for the column names in the dictionary, which is what you did for MissingValueCodes and SeeAlso. I understand that the data dictionaries/data files may have spaces in the the Id field. For RADx-rad, our guidelines required no spaces, but nonetheless, I seen spaces in some data files anyway.