search

bmitch / churn-php

Discover files in need of refactoring.
MIT License
1.36k stars 56 forks source link

Deprecated: Return type of RequirementCollection::getIterator() #344

Closed beeyev closed 2 years ago

beeyev commented 2 years ago

Hello, first of all, thanks for the great tool, I have been using it for quite a long time.
But it seems that the library needs to be updated in order to work with PHP 8.1 I get these errors:

Deprecated: Return type of HumbugBox391\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/churn/.box/src/RequirementCollection.php on line 15

Deprecated: Return type of HumbugBox391\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/churn/.box/src/RequirementCollection.php on line 19
Deprecated: Return type of Symfony\Component\Console\Helper\HelperSet::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/churn/vendor/symfony/console/Helper/HelperSet.php on line 104

Could you please fix that.

villfa commented 2 years ago

Thank you for your report.

I'm able to reproduce the problem when I run churn.phar in a PHP 8.1 environment. I'll find a way to fix this soon.

villfa commented 2 years ago

The upcoming release (1.6.0) will contain the fix for this issue.

villfa commented 2 years ago

Here the release: https://github.com/bmitch/churn-php/releases/tag/1.6.0