Kiwipup
commented
5 years ago Oh boy... I wish I had more feedback to give you but I looked through all of the projects in your portfolio and I, like Philip, cannot find a whole lot to critique! D: They are all beautiful as well as functional, I'm really blown away! The only thing I really noticed is that on your portfolio site, if you navigate to a different page that isn't the home page and scroll to the bottom there isn't any content. There is of course the background image which is lovely, but maybe a footer with some links or something similar might fill some of that empty space! I'm sorry if my feedback is lame haha, really though everything looks great down to the small details!
The way your projects are laid out in the portfolio (pagination) is nice, in that it keeps the user focused on one at a time, and gives a solid overview. The link to view on Github is a bit hidden/easy to miss. The chonological order is also neat, as you can see how you incorporated more technologies as you learned them.
Trudeau: Only compliements here. I think the biggest thing that makes this project stand out is the use of a dark color scheme. Those seem to be more difficult to use well, and you did a good job here with that. I love your readme instructions!
Blumbler: You mentioned in class that Trudeau's layout was borrowed from here (I can tell). One suggestion: clean up the junk blog posts.
Snake Game: Well, I spent 10 minutes playing it, and could'be continued playing more. The simple styling (didn't easy, just simple) adds a lot to it!
Contact Manager: Played with it andit was nice that you had validation on the fields. You also seem to like dark color themes. For your deployment instructions, you may want to add that it's specifically for Heroku in the title. As I was reading the readme. Also just noticed that you've got the heroku link in the description at the top of the repository. NICE!
Digital Clock: Well, the alarm is certainly bright enough when it goes off that no sound if needed! I like the military time, although in my wisdom I set an alarm in regular time, exepcting it to go off in military time. Lesson: there is so little logic to how we do things. You may want to explcitly state that the alarm needs to be set using military time. Repo looks good.
Simon: I'm partial to this, considering you were the determining factor in our group completing this. Looks as good as it did when it was first completed. Also looks amazing on a second monitor.
Oh My GIF!: Your GIF game is strong! Looking at your index.html, I noticed you've got emojis in your file...is that a real thing? An actual emoji in an html file?
Text Analyzer: The split display is a good look, as is the live updating. On the readme and the card in your profile I would add something about the program/code you used to do that, since it's more than just basis vue.js.
Gitten Mabelli: This is a great website - has all the info (except hours). You title "To Publish' in the readme is well written. It speficies Heroku, where was in the Contact Manager I think it assumes Heroku.
JS Weather App: The display looks like an apple watch face - good job adapting this project for your own use, and incorporating the google map! Stretch goal: make the enter key submit the zip code. Pressing enter currently resets the field if the focus isn't on the submit button.
Tic-Tac-Toe: Fun game, clean design. The computer isn't very smart :) Nothing to add to this one!
Michael Scott for Constable: The highlights you mentioned in your portfolio hit the nail on th ehead. 100%.
CA-Maker: Did you do this before bootcamp???? NICE!!!!
Mesh: Super cool - although I have no idea what it does or how to use it (besides press play). You may want a short "How To" at the top of the page, and a readme on github to explain the same.
I really enjoyed viewing all of your projects - it'll be neat to see what all you end up building in the future!