Support for custom not found handler

eaigner commented 11 years ago

You can now set a custom not found handler on the muxer

chris-baynes commented 11 years ago

Is there any reason this can't be merged? It would definitely be useful.

eaigner commented 11 years ago

@chris-baynes I moved to gorilla's mux and pat library, they're more flexible

chris-baynes commented 11 years ago

@eaigner will make that switch soon, thanks.

cenkalti commented 9 years ago

Why is this still not merged?

cespare commented 8 years ago

Merged, thanks. (Accidentally rebased the commit so it won't auto-close.)

I made some small adjustments in b9a994a8f6a5945800427435c904865e76dd6d42:

Added a test
Made the NotFound handler be called always if the pattern doesn't match. (Previously, the convenience behavior of 405 Method Not Allowed + setting the Allow header would kick in, instead of NotFound, if there is a matching pattern with a different associated method. It seems clear that NotFound should override that.)
Fleshed out the docs more, including mentioning that NotFound should be set before serving requests.

bmizerany / pat