search

bmizerany / pat

MIT License
1.43k stars 115 forks source link

Change Splats, and Improved API Docs, and fixed the Appending of Garbage to URLS #7

Closed georgerogers42 closed 12 years ago

bmizerany commented 12 years ago

Thank you. I really appreciate your work. Do you mind changing the commit messages "foo" and the one that says "ass". ;)

On Feb 25, 2012, at 12:17 AM, Georgereply@reply.github.com wrote:

You can merge this Pull Request by running:

git pull https://github.com/georgerogers42/pat.go master

Or you can view, comment on it, or merge it online at:

https://github.com/bmizerany/pat.go/pull/7

-- Commit Summary --

  • Modify URL.RawQuery only when necessary
  • Final / as splat instead of /*
  • foo
  • Fixed ?junk in urls
  • // Should i put a special form variable splat for this case
  • Fix README.md
  • Added Matt Nunogawa ass contributer
  • Improve API Docs

-- File Changes --

M README.md (5) M mux.go (23) M mux_test.go (49)

-- Patch Links --

https://github.com/bmizerany/pat.go/pull/7.patch https://github.com/bmizerany/pat.go/pull/7.diff

Reply to this email directly or view it on GitHub: https://github.com/bmizerany/pat.go/pull/7

georgerogers42 commented 12 years ago

Remove out of channel params. that was experimental.

georgerogers42 commented 12 years ago

Commit messages with names like "foo" are because either I'm lazy, or I don't have a good name so i just put something obviously bad.

georgerogers42 commented 12 years ago

And the one that said "ass" was a sticky s key and i did not notice before the commit was in

I do not know git too well at this point.

bmizerany commented 12 years ago

Awesome. Git certainly has a learning curve, but that's worth it.

I'll look at these tomorrow. Thank you.

On Feb 25, 2012, at 9:26 AM, Georgereply@reply.github.com wrote:

And the one that said "ass" was a sticky s key and i did not notice before the commit was in

I do not know git too well at this point.

Reply to this email directly or view it on GitHub: https://github.com/bmizerany/pat.go/pull/7#issuecomment-4174375

bmizerany commented 12 years ago

I'm having trouble getting through this patch in the time I have. Do you mind getting it in sync with the current master branch at bmizerany/master and making it one patch to fix only turning splats into what was discussed above? I really like this and want to get it in. Please help.

bmizerany commented 12 years ago

@georgerogers42 Have you been able to look into this? I'd love to get it in.

bmizerany commented 12 years ago

This has been taken care of. Thank you for your help. Here is the commit: 8b6a4316ecee897df01682c20b27e5b2014ca54f