add app engine example - Githubissues

bmizerany / pat

MIT License

1.43k stars 115 forks source link

add app engine example #9

Closed wickedchicken closed 12 years ago

wickedchicken commented 12 years ago

This adds a hello.go example that works within app engine. A more full project has been created here: https://github.com/wickedchicken/hello-pat

bmizerany commented 12 years ago

Thank you.

I'm not familiar with Go on AppEngine. Do you mind describing why the error handling, logging, and github.com/bmizerany/ import prefix have been removed?

wickedchicken commented 12 years ago

AppEngine already gives you an http connection, obviating the need for a ListenAndServe call. The logging and error handling in that example were associated with the ListenAndServe call, making them not needed either. As I'm new to both, this was non-obvious.

As for the import change, this is because I could only get things to work by statically including packages in the application directory. It may be that AE does support non-local packages and I did something incorrect in my dev environment.

bmizerany commented 12 years ago

Thank you for explaining.

A few things:

Do you think this explanation in comments at the top of the example file would help users understand why it looks the way it does?
Would something like goven would make bring in pat to your source tree easier?

wickedchicken commented 12 years ago

[1] That seems reasonable, especially since this is arguably a very specific example. The reason I'm asking for its inclusion is because Heroku and App Engine appear to be the only major Go hosting options at the moment. I'm assuming the normal example would work directly in a Heroku app?

[2] I hadn't heard of goven before, and it may indeed make things cleaner. Let me look into it.

bmizerany commented 12 years ago

You're right. I should put together a Heroku example as well.

On May 15, 2012, at 8:37 AM, Mike Stipicevicreply@reply.github.com wrote:

[1] That seems reasonable, especially since this is arguably a very specific example. The reason I'm asking for its inclusion is because Heroku and App Engine appear to be the only major Go hosting options at the moment. I'm assuming the normal example would work directly in a Heroku app?

[2] I hadn't heard of goven before, and it may indeed make things cleaner. Let me look into it.

Reply to this email directly or view it on GitHub: https://github.com/bmizerany/pat/pull/9#issuecomment-5719008

wickedchicken commented 12 years ago

Turns out that AE actually does handle URL imports (something in my local dev environment was borked). I've modified the example to reflect this (and added commentary on the top as requested).