If the next 6 items in the stream are [c, c, c, c, c, c], the Stream will have a count of 48 for c and 45 for b, but min will still point to "c" when it should be pointing to "b".
At this point if you add a new item, "f", it will replace "c" instead of replacing "b" even though "c" has a higher count.
The fix
Keep a reference to the actual minimum Element at all times using container/heap.
(This is #3 with cleaner commits, but two years later. Sorry about the delay.)
I found a degenerate case in topk, added a test for it, and fixed it.
The bug
Suppose you have the following item frequencies:
If the next 6 items in the stream are [c, c, c, c, c, c], the Stream will have a count of 48 for c and 45 for b, but
min
will still point to"c"
when it should be pointing to"b"
.At this point if you add a new item,
"f"
, it will replace"c"
instead of replacing"b"
even though"c"
has a higher count.The fix
Keep a reference to the actual minimum Element at all times using
container/heap
.(This is #3 with cleaner commits, but two years later. Sorry about the delay.)