bmizerany / perks

Effective Computation of Things
BSD 2-Clause "Simplified" License
186 stars 53 forks source link

topk's Query() returns the full sample slice if the slice length is less than k #4

Closed daneharrigan closed 10 years ago

bmizerany commented 10 years ago

Do you mind adding a test to reproduce the problem and I'll merge this in?

daneharrigan commented 10 years ago

@bmizerany there you go. thanks for the reminder

bmizerany commented 10 years ago

Do you mind re-writing it as a table-driven test? I'd like to get away from the old way.

daneharrigan commented 10 years ago

@bmizerany updated to a table-driven test. let me know if i've missed anything else

bmizerany commented 10 years ago

Thanks! Rebased and merged.