search

bmj-autonomous / donkey_ai

self driving car
MIT License
0 stars 1 forks source link

Save images to PNG #2

Open MarcusJones opened 6 years ago

MarcusJones commented 6 years ago

Add switch to enable uncompressed

octaexon commented 6 years ago

In principle, this is a simple change to one line of code: https://github.com/MarcusJones/donkey_ai/blob/6933a31db626f79e17414aaa4d103d6721512a8c/donkeycar/parts/datastore.py#L320 but this would be a hardcoded change each time one wanted to switch file formats. Probably, a better option would be to specify the format in the configuration file, or maybe a simple "compression" switch as @MarcusJones mentioned. However, this requires changing the interfaces of the Tub and Tub-related classes and would have to be traced throughout the code where they are called. This is not much work at all, and I'll implement it in the soon in a separate branch, but it will clearly break future compatibility of this "part" with the original donkey repo.

Again, I don't care too much about breaking changes but any thoughts would be welcome.