Add ReadM and Parser instances for more stdlib types, closes #4

bmjames / scala-optparse-applicative

Scala port of Paolo Capriotti's optparse-applicative library. This repository is no longer maintained; newer versions exist in this fork: https://github.com/xuwei-k/optparse-applicative

BSD 3-Clause "New" or "Revised" License

72 stars 9 forks source link

Add ReadM and Parser instances for more stdlib types, closes #4 #5

Closed adelbertc closed 9 years ago

adelbertc commented 9 years ago

Note: There is currently overloading on short and long for the ReadM[Short] and ReadM[Long] - the names were chosen to match the existing str and int names. Let me know if you'd like me to name them differently.

bmjames commented 9 years ago

Hi, thanks for this.

I'm not keen on the overloading, but I'm not sure which route I'd prefer to take to avoid that. Options that spring to mind so far:

Rename these members, to something like readInt, readChar etc.
Move all the ReadM instances somewhere else, for example the ReadM companion object, and not have them imported by default from net.bmjames.opts._

Does either sound sensible to you, or are they both potentially annoying?

adelbertc commented 9 years ago

I think prefixing with read sounds OK and less intrusive than having them not imported from net.bmjames.opts - thoughts?

adelbertc commented 9 years ago

@shajra

bmjames commented 9 years ago

@adelbertc let's go with the read prefixes for now, then. I'll merge this as I've renamed them on my copy. Thanks!