search

bmjames / scala-optparse-applicative

Scala port of Paolo Capriotti's optparse-applicative library. This repository is no longer maintained; newer versions exist in this fork: https://github.com/xuwei-k/optparse-applicative
BSD 3-Clause "New" or "Revised" License
72 stars 9 forks source link

upgrade scala to 2.11.8 and scalaz to 7.2.2 #9

Closed SamRoberts closed 8 years ago

SamRoberts commented 8 years ago

Hi James,

We have recently upgraded to scala 2.11.8 and scalaz 7.2.2 where I work, which means we would like a version of scala-optparse-applicative compatible with scalaz 7.2. I am not sure what other users are using, but as long as they are happy it would be great if you could merge this and release a new version targeting scalaz 7.2.

Thanks, Sam

bmjames commented 8 years ago

Hi @SamRoberts,

Thanks for this. I was about to merge this when I saw that @nuttycom had made a very similar pull request (#10). I decided to merge #10 because it updates scalaz to a slightly newer version (7.2.4 vs 7.2.2).

If you're willing to resolve the conflicts on this branch, I'd be happy to merge it in to get the Scala version bump.

SamRoberts commented 8 years ago

No worries @bmjames.

10 had a better tweak to https://github.com/bmjames/scala-optparse-applicative/blob/master/src/main/scala/net/bmjames/opts/types/ParserM.scala#L30 anyway.

I have rebased my PR to include one commit with the scala version bump plus another commit with a few other minor tweaks. Can easily get rid of the second commit if you prefer. Let me know.

bmjames commented 8 years ago

Looks good, thanks!

bmjames commented 8 years ago

I'll cut a 0.4 release some time in the next few days, to get these upgrades onto Bintray.

SamRoberts commented 8 years ago

Thanks a lot, much appreciated