search

bmlt-enabled / bmlt-api-explorer

https://explorer.bmlt.app/
1 stars 0 forks source link

Add top level language selection #9

Open dgershman opened 3 years ago

dgershman commented 3 years ago

Not sure if you considered this, but the original version of this was in English only. It might make sense to add a language dropdown and create resource files ahead of time, in anticipation that this would be translated into multiple languages.

GarrettWeinberg commented 3 years ago

@radius314 im looking into solutions for this. I did find a couple i18n packages that would probably be suitable to make this work. I dont have much experience working with translations outside of wordpress, so i am open to any insight or suggestions on how to handle this. Also, is it safe to assume that the data that is returned from the server will already be translated?

dgershman commented 3 years ago

Yes it would be safe to assume that, we'd pass in the appropriate language code to each query to get that data.

On Wed, Feb 24, 2021 at 12:34 PM GarrettWeinberg notifications@github.com wrote:

@radius314 https://github.com/radius314 im looking into solutions for this. I did find a couple i18n packages that would probably be suitable to make this work. I dont have much experience working with translations outside of wordpress, so i am open to any insight or suggestions on how to handle this. Also, is it safe to assume that the data that is returned from the server will already be translated?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/bmlt-api-explorer/issues/9#issuecomment-785246694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOD3O5SDHRSZITP6HXDBVLTAU2ARANCNFSM4VFB6K3Q .