bmlt-enabled / bmlt-root-server

This is the Main Root Server Repo for the Basic Meeting List Toolbox
MIT License
13 stars 14 forks source link

Show accurate history for data deletions #925

Open tempsaint opened 9 months ago

tempsaint commented 9 months ago

When completely deleting field data the history only shows "... was deleted" instead of showing the actual text that was deleted. If the data is edited from something to something else, the history shows the actual change. It should do that when deleting all content in the field as well.

image
jbraswell commented 9 months ago

I think the data all exists in the database, so we could do this in the new UI.

tempsaint commented 9 months ago

I think the data all exists in the database, so we could do this in the new UI.

Bummer - I was hoping it would be a simple change in code somewhere. I'm assuming whatever logic displays the history is looking at the previous field value and the current field value, but if the current field value is null then it just displays "... was deleted" rather than the previous content. I'm no software engineer but the way I wrote my assumption it seems like the code might be doing something extra to display the "... was deleted" instead of just displaying the previous and current content.

jbraswell commented 9 months ago

You're right. That's probably how it works. All of the data is there, so we can fix it in the new UI. It's moving along, even if slowly.

Unless there are actual bugs, I essentially want to feature freeze the old UI.

This doesn't seem like a bug, but more like unfortunate UX that no one has mentioned until now.

jbraswell commented 9 months ago

It's possible those messages are generated in the already rewritten server side code. I honestly can't remember. If that's the case, we could fix it sooner, since the change would be in the new PHP code and not the old UI code.