search

bmlt-enabled / bread

BMLT Meeting List Generator Plugin For Wordpress https://wordpress.org/plugins/bread/
https://wordpress.org/plugins/bread/
GNU General Public License v2.0
6 stars 9 forks source link

[service_body_1] shortcode is showing IDs and parent. #109

Closed dgershman closed 5 years ago

dgershman commented 5 years ago
image

configuration: archsearch-canada09-08-2019.json.zip

otrok7 commented 5 years ago

I've been unable to reproduce this behavior.

otrok7 commented 5 years ago

@radius314 : I can provoke this behavior if I use a custom query. Is it possible that in the version that produced this error, you had a custom query?

dgershman commented 5 years ago

Yes it is using that feature.

On Mon, Sep 9, 2019 at 5:44 AM otrok7 notifications@github.com wrote:

@radius314 https://github.com/radius314 : I can provoke this behavior if I use a custom query. Is it possible that in the version that produced this error, you had a custom query?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/bread/issues/109?email_source=notifications&email_token=AAOD3O7W7MYN7WHRXVGSIR3QIYLGNA5CNFSM4IUUAXJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6G5IRQ#issuecomment-529388614, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOD3O5GOBPKWQCWWWB7WN3QIYLGNANCNFSM4IUUAXJQ .

dgershman commented 5 years ago

It’s also using custom query dynamic shortcodes.

On Mon, Sep 9, 2019 at 7:30 AM Danny Gershman danny.gershman@gmail.com wrote:

Yes it is using that feature.

On Mon, Sep 9, 2019 at 5:44 AM otrok7 notifications@github.com wrote:

@radius314 https://github.com/radius314 : I can provoke this behavior if I use a custom query. Is it possible that in the version that produced this error, you had a custom query?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/bread/issues/109?email_source=notifications&email_token=AAOD3O7W7MYN7WHRXVGSIR3QIYLGNA5CNFSM4IUUAXJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6G5IRQ#issuecomment-529388614, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOD3O5GOBPKWQCWWWB7WN3QIYLGNANCNFSM4IUUAXJQ .

otrok7 commented 5 years ago

Not sure what you mean by dynamic shortcodes... Am Montag, 9. September 2019, 13:32:04 MESZ hat Danny Gershman notifications@github.com Folgendes geschrieben:

It’s also using custom query dynamic shortcodes.

On Mon, Sep 9, 2019 at 7:30 AM Danny Gershman danny.gershman@gmail.com wrote:

Yes it is using that feature.

On Mon, Sep 9, 2019 at 5:44 AM otrok7 notifications@github.com wrote:

@radius314 https://github.com/radius314 : I can provoke this behavior if I use a custom query. Is it possible that in the version that produced this error, you had a custom query?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/bread/issues/109?email_source=notifications&email_token=AAOD3O7W7MYN7WHRXVGSIR3QIYLGNA5CNFSM4IUUAXJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6G5IRQ#issuecomment-529388614, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOD3O5GOBPKWQCWWWB7WN3QIYLGNANCNFSM4IUUAXJQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

dgershman commented 5 years ago

There is a feature that allows you to set some shortcode values are dynamically set through a query string value. This allows for trivial changes like titles or a minor query difference without having to have multiple templates. The use case is a single template for all 50 states.

dgershman commented 5 years ago

https://github.com/bmlt-enabled/bread/blob/unstable/bmlt-meeting-list.php#L1487-L1491

otrok7 commented 5 years ago

Very cool. Bread can still surprise me. Do you think that this and the query string in the html query should be _REQUEST instead of _GET. Also, maybe make this feature available in "custom_content" and "last_page" sections, too. What do you think?

dgershman commented 5 years ago

There isn't much consumption of this feature, not sure it would be worth the maintenance of it. Might be fine either way.

otrok7 commented 5 years ago

I don't think the average user is going to generate a query string and call Bread. On the other hand, maybe this is a possibility for us as developers. I had an early version of the meeting map that was for use by the regional PI committee. The use case is, they wanted to inform therapies where nearby NA meetings are. The user could select the location and zoom factor, and then with a push of a button, you could generate a query to send to Bread. Bread would generate the meetings using a nice template, suitable for framing, or hanging up on the bulletin board....

otrok7 commented 5 years ago

fixed in 2.1.2

dgershman commented 5 years ago

I have tested this and it looks good to me. Thanks.