bmlt-enabled / bread

BMLT Meeting List Generator Plugin For Wordpress https://wordpress.org/plugins/bread/
https://wordpress.org/plugins/bread/
GNU General Public License v2.0
6 stars 9 forks source link

Non-Virtual Meeting Being Displayed as Virtual #173

Closed tempsaint closed 2 years ago

tempsaint commented 3 years ago

On one of our meeting lists we have an in-person meeting showing up on the virtual meetings additional list. Attached is a screenshot where you can clearly see that neither VM nor HY are one of the format codes of the meeting. sfca-meeting-list-20210910_Page_1

Also attached is the configuration file. I had to zip the json as github won't let me attach it natively. connecticut-region-of-narcotics-anonymous-fairfield-cty09-10-2021.json.zip

When I change the additional list to display either Hybrid Meeting or Virtual Meeting (no "s") the meeting correctly appears on the main list among the in-person meetings. This only happens when using the "Virtual Meetings" (with an "s" option (to pull both hybrid and virtual).

tempsaint commented 3 years ago

Okay... apparently the problem was that there was still a virtual meeting link in the location information. Once removed this problem is resolved.

So, the code for additional lists uses the virtual meeting link field instead of the formats (VM and HY) to determine if the meeting fits the criteria for "virtual meetings" whereas the condition for "virtual meeting" or "hybrid meeting" obviously uses the format codes as the criteria.

I'm not sure if this is still an issue that could be resolved by using the format codes as criteria or if we just need to document this issue. So I'm not closing this. Developers will need to make that determination.