search

bmlt-enabled / crouton

BMLT Tabbed-based view for Wordpress https://wordpress.org/plugins/crouton/ and any website. https://github.com/bmlt-enabled/crouton/tree/master/croutonjs
GNU General Public License v2.0
4 stars 14 forks source link

Accessibility for Tables #178

Open kcad opened 4 years ago

kcad commented 4 years ago

The tables generated by crouton aren't rendering properly in a screen reader, via messages from 2 additional needs addicts in the Carolina Region. If the headers could be marked up so a screen reader properly reads the headers and content it would make it more accessible to addicts who depend on assistive technology on websites. WebAIM provides guidance to markup the headers and rows - https://webaim.org/techniques/tables/data . Additonally WCAG offers guidance on the markup in the quick reference - https://www.w3.org/WAI/WCAG21/quickref/. The suggested target would be Level AA.

dgershman commented 4 years ago

Can you provide information about how to reproduce the issue?

On Dec 17, 2019, at 9:32 AM, Kevin Cadigan notifications@github.com wrote:

The tables generated by crouton aren't rendering properly in a screen reader, via messages from 2 additional needs addicts in the Carolina Region. If the headers could be marked up so a screen reader properly reads the headers and content it would make it more accessible to addicts who depend on assistive technology on websites. WebAIM provides guidance to markup the headers and rows - https://webaim.org/techniques/tables/data https://webaim.org/techniques/tables/data . Additonally WCAG offers guidance on the markup in the quick reference - https://www.w3.org/WAI/WCAG21/quickref/ https://www.w3.org/WAI/WCAG21/quickref/. The suggested target would be Level AA.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/crouton/issues/178?email_source=notifications&email_token=AAOD3OZWOBCUTY7DE2TAU33QZAM3DA5CNFSM4J3T6I62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IA42EKA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOD3O6C5XBXFB7WZNLTOHLQZAM3DANCNFSM4J3T6I6Q.

dgershman commented 4 years ago

I have submitted a pull request for this https://github.com/bmlt-enabled/crouton/pull/194

dgershman commented 4 years ago

I have also tested for color blindness, and I believe that the default jack theme works ok.

dgershman commented 4 years ago

https://archives.bmlt.app/crouton/crouton-build410-3e171d1cfa791c92a7e62e1f21aeb956d5086b85.zip

dgershman commented 4 years ago

It might be good to get this going soon because of the virtual-na.org site being on crouton now.

alanb2718 commented 3 years ago

@kcad - I'm a new person on the project, with some interests in accessibility. @radius314 says that this pull request is waiting for you to review and to run tests with screen readers. Can I help move this along somehow?

kcad commented 3 years ago

Hi Alan, absolutely 👍 have you done ADA compliance testing? If so i was going to target AA level wcag 3.0. I just haven’t had the time.

Sincerely, Kevin Cadigan | www.kc-designs.net

Winston Salem, NC

kcadigan@triad.rr.com

c. 336.926.2845

On Jul 30, 2020, at 7:25 PM, Alan Borning notifications@github.com wrote:

 @kcad - I'm a new person on the project, with some interests in accessibility. @radius314 says that this pull request is waiting for you to review and to run tests with screen readers. Can I help move this along somehow?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

alanb2718 commented 3 years ago

Thanks Kevin - no, I haven't done ADA compliance testing. What about this as a plan for moving this along: by now pull request #194 that would fix this issue has probably gotten stale. How about if I dust it off and test it as well as I can. Then, when you have time, we schedule a zoom call with screen sharing, and you could do the final compliance testing (or maybe even better tell me what buttons I should be pushing so that I do the testing on my end and learn more about it).

Or if this is more than you have time for, even with some novice help from me, we will come up with Plan B. Alan

dgershman commented 2 years ago

@prbrian If you know of someone who can help validate that any of this is working. I have re-integrated my changes on #194 from Feb 2020.

https://archives.bmlt.app/crouton/crouton-build881-8f2c7ecd12e5620283e838d963149730d4f8b630.zip

kcad commented 2 years ago

Hi Danny, if you can put this on a test site I can check it with voiceover. It would also be good if we can get someone with a pc to check with NVDA.

Sincerely, Kevin Cadigan

Winston Salem, NC

@.***

c. 336.926.2845

On Jul 11, 2021, at 7:47 PM, Danny Gershman @.***> wrote:

 @prbrian If you know of someone who can help validate that any of this is working. I have re-integrated my changes on #194 from Feb 2020.

https://archives.bmlt.app/crouton/crouton-build881-8f2c7ecd12e5620283e838d963149730d4f8b630.zip

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

prbrian commented 2 years ago

Including Heather G, our Additional Needs Workgroup leader.

Heather, you know anyone who can check this out?

Brian S. Public Relations Representative Fellowship Development Team Ontario Region and Manitoba Area of Narcotics Anonymous Cell: (289) 668-6974 Toll-free: 1-888-811-3887 Email: @.*** Website: www.orscna.org

On Jul 11, 2021, at 7:47 PM, Danny Gershman @.***> wrote:

 @prbrian If you know of someone who can help validate that any of this is working. I have re-integrated my changes on #194 from Feb 2020.

https://archives.bmlt.app/crouton/crouton-build881-8f2c7ecd12e5620283e838d963149730d4f8b630.zip

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

prbrian commented 2 years ago

Hi Danny, what exactly do you want checked out?

On Sun, Jul 11, 2021 at 8:39 PM Narcotics Anonymous @.***> wrote:

Including Heather G, our Additional Needs Workgroup leader.

Heather, you know anyone who can check this out?

Brian S. Public Relations Representative Fellowship Development Team Ontario Region and Manitoba Area of Narcotics Anonymous Cell: (289) 668-6974 Toll-free: 1-888-811-3887 Email: @.***

Website: www.orscna.org

On Jul 11, 2021, at 7:47 PM, Danny Gershman @.***> wrote:



@prbrian https://github.com/prbrian If you know of someone who can help validate that any of this is working. I have re-integrated my changes on

194 https://github.com/bmlt-enabled/crouton/pull/194 from Feb 2020.

https://archives.bmlt.app/crouton/crouton-build881-8f2c7ecd12e5620283e838d963149730d4f8b630.zip

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/crouton/issues/178#issuecomment-877880584, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSVTECFG4K5DNO7LQGJCZLTXIUQTANCNFSM4J3T6I6Q .

-- ((((HUGS)))) Heather

prbrian commented 2 years ago

Ok, I figured it out, I will ask one of the task force members to check it out.

On Sun, Jul 11, 2021 at 8:39 PM Narcotics Anonymous @.***> wrote:

Including Heather G, our Additional Needs Workgroup leader.

Heather, you know anyone who can check this out?

Brian S. Public Relations Representative Fellowship Development Team Ontario Region and Manitoba Area of Narcotics Anonymous Cell: (289) 668-6974 Toll-free: 1-888-811-3887 Email: @.***

Website: www.orscna.org

On Jul 11, 2021, at 7:47 PM, Danny Gershman @.***> wrote:



@prbrian https://github.com/prbrian If you know of someone who can help validate that any of this is working. I have re-integrated my changes on

194 https://github.com/bmlt-enabled/crouton/pull/194 from Feb 2020.

https://archives.bmlt.app/crouton/crouton-build881-8f2c7ecd12e5620283e838d963149730d4f8b630.zip

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/crouton/issues/178#issuecomment-877880584, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSVTECFG4K5DNO7LQGJCZLTXIUQTANCNFSM4J3T6I6Q .

-- ((((HUGS)))) Heather

prbrian commented 2 years ago

I don't understand - this is asking me to download something - please let me know what the purpose of this request is - I can't ask someone to download something without knowing what you want - is this for the blind, deaf or physically challenged or all three?

On Sun, Jul 11, 2021 at 8:39 PM Narcotics Anonymous @.***> wrote:

Including Heather G, our Additional Needs Workgroup leader.

Heather, you know anyone who can check this out?

Brian S. Public Relations Representative Fellowship Development Team Ontario Region and Manitoba Area of Narcotics Anonymous Cell: (289) 668-6974 Toll-free: 1-888-811-3887 Email: @.***

Website: www.orscna.org

On Jul 11, 2021, at 7:47 PM, Danny Gershman @.***> wrote:



@prbrian https://github.com/prbrian If you know of someone who can help validate that any of this is working. I have re-integrated my changes on

194 https://github.com/bmlt-enabled/crouton/pull/194 from Feb 2020.

https://archives.bmlt.app/crouton/crouton-build881-8f2c7ecd12e5620283e838d963149730d4f8b630.zip

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/crouton/issues/178#issuecomment-877880584, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSVTECFG4K5DNO7LQGJCZLTXIUQTANCNFSM4J3T6I6Q .

-- ((((HUGS)))) Heather

dgershman commented 2 years ago

This is a special version of the plug-in. It's for a visually impaired person.

dgershman commented 2 years ago

You would uninstall your version from the Wordpress directory and instead upload this version. It's recommended that you use a test instance.

dgershman commented 2 years ago

@prbrian @kcad I have added the test plugin to this site on this page. https://demo.bmlt.app/crouton/

prbrian commented 2 years ago

Hey Heather. Here's a link to use to test it out. Can you ask your friend to help?

Link: https://demo.bmlt.app/crouton/

On Thu, Jul 15, 2021 at 7:47 PM Danny Gershman @.***> wrote:

@prbrian https://github.com/prbrian @kcad https://github.com/kcad I have added the test plugin to this site on this page. https://demo.bmlt.app/crouton/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/crouton/issues/178#issuecomment-881078603, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSVTEHYXRDNYKTW3SH555DTX5XQTANCNFSM4J3T6I6Q .

-- Brian S. Public Relations Coordinator Fellowship Development Team Ontario Region & Manitoba Area of Narcotics Anonymous Cell: (289) 668-6974 Toll-free: 1-888-811-3887 Website: www.orscna.org Email: @.***

prbrian commented 2 years ago

Hey Heather. Here's a link to use to test it out. Can you ask your friend to help?

Link: https://demo.bmlt.app/crouton/

On Thu, Jul 15, 2021 at 8:39 PM Narcotics Anonymous @.***> wrote:

Hey Heather. Here's a link to use to test it out. Can you ask your friend to help?

Link: https://demo.bmlt.app/crouton/

On Thu, Jul 15, 2021 at 7:47 PM Danny Gershman @.***> wrote:

@prbrian https://github.com/prbrian @kcad https://github.com/kcad I have added the test plugin to this site on this page. https://demo.bmlt.app/crouton/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/crouton/issues/178#issuecomment-881078603, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSVTEHYXRDNYKTW3SH555DTX5XQTANCNFSM4J3T6I6Q .

-- Brian S. Public Relations Coordinator Fellowship Development Team Ontario Region & Manitoba Area of Narcotics Anonymous Cell: (289) 668-6974 Toll-free: 1-888-811-3887 Website: www.orscna.org Email: @.***

-- Brian S. Public Relations Coordinator Fellowship Development Team Ontario Region & Manitoba Area of Narcotics Anonymous Cell: (289) 668-6974 Toll-free: 1-888-811-3887 Website: www.orscna.org Email: @.***

tempsaint commented 2 years ago

I'm not an accessibility expert, let me say that first. But I took a look at the demo site. I used WAVE (https://wave.webaim.org/) as an initial test for accessibility and it reports contrast issues (the orange for the Weekday button the selected day of the week tab) against the darker orange crouton background. That's should be a simple theme issue.

There were also alerts of missing labels (7 of them) and I think those are on the dropdown filters (Cities, Groups, Venue Types, Areas, Locations, Zips, and Formats).

dgershman commented 2 years ago

I think we need to consider removing/changing any themes that are not compatible.

pjaudiomv commented 2 years ago

I think we need to consider removing/changing any themes that are not compatible.

Removing all but the orange monster theme works for me

dgershman commented 2 years ago

We don't have to remove it, we simply need to make a few changes so color contrasts a little better.

dgershman commented 2 years ago

I have made a new page to test this with a different theme (we can sort out the theme issues later).

I have also updated the plugin to add a few more aria labels.

https://demo.bmlt.app/accessibility-test/

tempsaint commented 2 years ago

There's still some contrast issues. Looks like the white on orange in the active button/tab is no good. And the grey text in the filter dropdowns is too light.

The missing label alerts are gone.

prbrian commented 2 years ago

Brian here is the reply from my other friend

---------- Forwarded message ------- Good morning Heather, I was able to reach the site with my screen reading software (called JAWS) and even though I did not find the word “meetings link” I was able to discern from “weekday” to click this link first and then there is certainly more then one way to locate a meeting or filter your search. The lack of the word “meetings” is just a perspective. Also, the addition of “keyboard shortcuts” is helpful and the designers may want to add short cuts for navigating a table for the meetings, I had to use Alt plus up or down arrow initially. Thank you for asking for my input, glad to help any way I can. Hugs, Cheri

Brian S. Public Relations Representative Fellowship Development Team Ontario Region and Manitoba Area of Narcotics Anonymous Cell: (289) 668-6974 Toll-free: 1-888-811-3887 Email: @.*** Website: www.orscna.org

On Jul 16, 2021, at 10:28 AM, Danny Gershman @.***> wrote:

 I have made a new page to test this with a different theme (we can sort out the theme issues later).

I have also updated the plugin to add a few more aria labels.

https://demo.bmlt.app/accessibility-test/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

kcad commented 2 years ago

In using voiceover on a mac here’s what I've found - the day speaks that it's in an empty group then says Friday. Their isn’t a caption of the table which could be ” {Day} meetings “. The day in {} would be based on the selection of the day. The way readers interpret tables is based on column groups and rows are associated based on the column. First column could be named “day time and format” the Second could be ” group name and address” ,the third would be”map and link” Here’s a tutorial from W3.org that might help - https://www.w3.org/WAI/tutorials/tables/irregular/ BTW - This is a great start in ADA compliance for these tables.