bmlt-enabled / crouton

BMLT Tabbed-based view for Wordpress https://wordpress.org/plugins/crouton/ and any website. https://github.com/bmlt-enabled/crouton/tree/master/croutonjs
GNU General Public License v2.0
5 stars 14 forks source link

Please we want to use fields marked "This is never displayed in normal meeting searches." #268

Closed gingerwatch closed 4 years ago

gingerwatch commented 4 years ago

Currently the "OBSERVER" user can only see information in hidden fields (those marked "This is never displayed in normal meeting searches.") if they are signed in to the ROOT SERVER (like at https://my/root/server/main_server/).

We would like our local OBSERVERS, who can only see meeting information but not make changes, to view hidden information. The original intent of Observers was so that people manning the Help Line other such trusted servants could have extra info not available to the viewing public. This is a perfect use of the Observer position, and use of the hidden information.

Currently our Observers do enjoy the different layout and map with pins they get when logging in to our local BMLT server.

But we would love to make use of those hidden fields to include secret info like "Tom R. holds the key to the church, his number is xxx-xxx-xxxx" Or "Lisa F. lives nearby and is willing to give rides, her number is xxx-xxx-xxxx".

jbraswell commented 4 years ago

Hi Ginger. What is the actual problem you are trying to solve? Are you requesting a way for volunteers to find contact info for local groups that they’re referring the callers to?

dgershman commented 4 years ago

Was it intended that this ticket was created on this project? Or were you referring to the https://github.com/bmlt-enabled/bmlt-root-server? Or both?

jbraswell commented 4 years ago

I asked her on FB to create it here, because the value she's looking for is related to fielding phone calls. I also said that it may get implemented somewhere besides Yap, but that this is the right place to start the discussion, since it's primarily yap users (volunteers) that benefit.

jbraswell commented 4 years ago

The original discussion was around volunteers getting access to what's in the hidden fields in the root server so that they can better connect callers with local resources.

My personal opinion is that this shouldn't be implemented in the root server - the root server should just be for CRUD operations and querying via API. I do not know if it should be part of Yap or some new thing.

dgershman commented 4 years ago

I do see value in it, but the meeting information would not be pulled in Yap ever. The information is relevant to meetings, information volunteers need to access. If anything there should be a way to login as an observer and then reload a crouton page and see the information (or other apps). I feel this is the right approach, because most helplines are not on yap.

dgershman commented 4 years ago

The cookie from the login, would essentially act as the "token" for the API response to show the additional information. Assuming they are accessing from the same browser session.

jbraswell commented 4 years ago

Yeah, I think I agree with you. There could be a new WP plugin basically wraps crouton. It could prompt for a login page, and after you authenticate show meetings with hidden data.

dgershman commented 4 years ago

This could be part of crouton essentially. A first pass, I would not build the login page right away. Crouton would be modified to display the "hidden" fields as part of the data template. Because you are logged in as an observer, those data points should appear. If you aren't they are invisible. If there is enough interest in the feature, build out the login as a convenience feature. I wouldn't go and build a login until we know if there is traction.

jbraswell commented 4 years ago

I like it

dgershman commented 4 years ago

This is trivial. I could code this up in a few hours.

dgershman commented 4 years ago

Moving this ticket to crouton.

dgershman commented 4 years ago

@jbraswell do you have a list of these fields that are hidden (stock fields)? Or is there a way to query that dynamically (even better)?

jbraswell commented 4 years ago

Let me fire up the craptop and figure out the best way to track them down.

jbraswell commented 4 years ago
mysql> select `key` from sezf4_comdef_meetings_data where meetingid_bigint=0 and visibility=1;
+-----------------+
| key             |
+-----------------+
| contact_phone_2 |
| contact_email_1 |
| contact_phone_1 |
| contact_email_2 |
| contact_name_1  |
| contact_name_2  |
+-----------------+
6 rows in set (0.00 sec)
gingerwatch commented 4 years ago

Thanks for all your help! Does this mean Observers will get to see the hidden info?

jbraswell commented 4 years ago

Yes. They may have to go to a different place to see it for now, but that's the idea.

dgershman commented 4 years ago

@gingerwatch how does this look to you?

Screen Shot 2020-07-11 at 2 31 10 PM

gingerwatch commented 4 years ago

It looks GREAT! But ... did you realize the Observer currently gets a different layout? I don't know if you want to work within the layout that an Observer currently gets. It is a different look than what you are showing here. It has a map with pins at the top, and meeting info in rows below the map.

jbraswell commented 4 years ago

@gingerwatch this is intended to be a complete replacement for the existing observer view. The existing one is super old and mostly broken, so we wanted to replace it with something more modern and maintained.

dgershman commented 4 years ago

As @jbraswell mentioned we will swap out the current display. I will be sure to include the map with the pins on that view.

gingerwatch commented 4 years ago

You guys are like Gods. I never thought all this would be possible. The phone line was liking the map with pins. This is so unbelieveable. Maybe I can learn some code and help you guys. I'm taking online Wordpress classes now.

alanb2718 commented 4 years ago

Hey @gingerwatch - one place to start getting involved might be the BMLT documentation project. It looks like a new set of docs is being written using WordPress - so that could make use of your new knowledge! (I'm not working on that part of the project myself but I see it going on.)

gingerwatch commented 4 years ago

So has this happened yet? When logging in as Observer - I still have the old view, missing the hidden info. Maybe it'll take awhile to get the update? We have a PR meeting tomorrow so I thought I'd check in so I can bring info back to the committee.

jbraswell commented 4 years ago

We cut a new release (2.15.4), and the release has this feature, but we haven't officially announced it yet.

You won't get the update until your BMLT root server administrator installs it. You can get the feature now, but your admin will need to upgrade to 2.15.4.

gingerwatch commented 4 years ago

Understood, thank you.