search

bmlt-enabled / crouton

BMLT Tabbed-based view for Wordpress https://wordpress.org/plugins/crouton/ and any website. https://github.com/bmlt-enabled/crouton/tree/master/croutonjs
GNU General Public License v2.0
5 stars 14 forks source link

Time Zone not Showing Up with url shortcode #292

Open californiasteve opened 4 years ago

californiasteve commented 4 years ago

Using the url parameter the time formats correctly but the time zone doesn't show. I'm using the HH:mm (h:mma) z short code on this page https://na-italia.org/riunioni/?root_server=https://na-italia.info/main_server&custom_query=%26meeting_key%3Dlocation_province%26meeting_key_value%3DToscana&language=it-IT&int_start_day_id=2&time_format=HH:mm%20(h:mma)%20z&this_title=Riunioni%20in%20Toscana&show_map=1

tempsaint commented 4 years ago

We're not getting the time zone to display on ctna.org using [bmlt_tabs time_format="HH:mm (h:mma) z"]

dgershman commented 4 years ago

Ok so if auto_tz_adjust is enabled then there is a check to see what the value of the new fields is for TZ otherwise it will guess what timezone the person is in. This is why it works on virtual-na.org.

If neither of these conditions is met, there is no timezone assumption made.

It could theoretically be possible to do a timezone lookup the same way Yap does with the Google APIs, however, TZs are being introduced into a future version of the root server negating this requirement. Also, this only works if latitude + longitude is set, and in some cases, there might be a virtual meeting that has no physical location but is set to a specific timezone. The timezone field in the root server is a bulletproof feature to implement your ask.

My suggestion would be to hold off on this feature until the time zone fields are generally available in the root server (https://github.com/bmlt-enabled/bmlt-root-server/issues/343).

dgershman commented 4 years ago

Changing this to an enhancement, because it never worked.