search

bmlt-enabled / crouton

BMLT Tabbed-based view for Wordpress https://wordpress.org/plugins/crouton/ and any website. https://github.com/bmlt-enabled/crouton/tree/master/croutonjs
GNU General Public License v2.0
5 stars 14 forks source link

Link to google maps should open in new tab #483

Closed GarrettWeinberg closed 1 month ago

GarrettWeinberg commented 1 month ago

Is your feature request related to a problem? Please describe. when looking at the meeting details modal, the link for google maps opens in the same tab.

Describe the solution you'd like add target="_blank" to any place that is opening an external site

Describe alternatives you've considered Tried adding a javascript snippet to our theme js file, but this modal is loaded after the DOM so this fix doesnt work.

Additional context Add any other context or screenshots about the feature request here.

otrok7 commented 1 month ago

The correct place to fix this is in the crouton settings, on the "Templates" tab. But in recent versions, target=_blank is already set. So you might try just setting the template to the default. Templates don't update automatically... I'm afraid to overwrite customizations.