search

bmlt-enabled / yap

Find meetings or someone to talk to over the phone leveraging a BMLT root server.
https://bmlt.app/yap
MIT License
9 stars 10 forks source link

Volunteer's not scheduled if timezone missing #1121

Closed klgrimley closed 2 weeks ago

klgrimley commented 3 weeks ago

If a volunteer shift does not have a timezone set it causes all volunteer shifts to fail. This can be visually seen in the schedule and calling results in no transfer to any volunteer

What version are you running? v4.3.5

What PHP version are you running? 8.2.22

Did this happen on prior versions to the one you are running (if so what version)? Initial install

To Reproduce Steps to reproduce the behavior:

  1. Go to Volunteers
  2. Create a test volunteer, properly fill out all info except timezone
  3. Enable volunteer and click save volunteers
  4. Schedule will be empty and incoming calls won't be transfered to volunteers

Expected behavior Should not allow saving if timezone not set

dgershman commented 2 weeks ago

How did you make it so that there is no time zone set?

klgrimley commented 2 weeks ago

It's not a required field so if you leave it blank it will save without a timezone chosen

dgershman commented 2 weeks ago

Yeah I could even figure out how you were able to set it as a blank value.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Kevin Grimley @.> Sent: Monday, August 26, 2024 8:46:01 AM To: bmlt-enabled/yap @.> Cc: Danny Gershman @.>; Comment @.> Subject: Re: [bmlt-enabled/yap] Volunteer's not scheduled if timezone missing (Issue #1121)

It's not a required field so if you leave it blank it will save without a timezone chosen

— Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/1121#issuecomment-2310127338, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOD3O6W5UZQT7XGERUHQ2LZTMPQTAVCNFSM6AAAAABM5APDKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGEZDOMZTHA. You are receiving this because you commented.Message ID: @.***>

klgrimley commented 2 weeks ago

At least for us the placeholder/default option is blank. Guessing that passes null or empty when saved. Screenshot 2024-08-26 at 8 48 20 AM

dgershman commented 2 weeks ago

Weird. Does it happen just for you? Or for other people?

Get Outlook for iOShttps://aka.ms/o0ukef

From: Kevin Grimley @.> Sent: Monday, August 26, 2024 8:48:52 AM To: bmlt-enabled/yap @.> Cc: Danny Gershman @.>; Comment @.> Subject: Re: [bmlt-enabled/yap] Volunteer's not scheduled if timezone missing (Issue #1121)

At least for us the placeholder/default option is blank. Guessing that passes null or empty when saved. Screenshot.2024-08-26.at.8.48.20.AM.png (view on web)https://github.com/user-attachments/assets/47d7cadd-9c31-4c91-99cf-b7beb59b1417

— Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/1121#issuecomment-2310132838, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOD3O5ZCDPBNLEZK2OBN33ZTMP3JAVCNFSM6AAAAABM5APDKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGEZTEOBTHA. You are receiving this because you commented.Message ID: @.***>

klgrimley commented 2 weeks ago

Looking at the rendered markup that's actually kind of interesting I would expect <option value="Africa/Abidjan">Africa/Abidjan</option> to be the default option

klgrimley commented 2 weeks ago

Both myself and one of our Area PR chairs have this happen. It was actually one of the shifts that she entered that brought it to my attention

dgershman commented 2 weeks ago

Any browser and/or OS in particular? The same result regardless or browser? Its supposed to use your computer time to determine the time zone you are in.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Kevin Grimley @.> Sent: Monday, August 26, 2024 8:51:50 AM To: bmlt-enabled/yap @.> Cc: Danny Gershman @.>; Comment @.> Subject: Re: [bmlt-enabled/yap] Volunteer's not scheduled if timezone missing (Issue #1121)

Both myself and one of our Area PR chairs have this happen. It was actually one of the shifts that she entered that brought it to my attention

— Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/1121#issuecomment-2310139158, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOD3OYRDXGWSEX3FS5YYLDZTMQGNAVCNFSM6AAAAABM5APDKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGEZTSMJVHA. You are receiving this because you commented.Message ID: @.***>

klgrimley commented 2 weeks ago

I'm mac. Happens on both my intel pro and M2 air. Both using chrome. I've asked the Area person what she was using and will let you know.

When using firefox it does populate with my timezone

klgrimley commented 2 weeks ago

Brave and Safari also do not populate. I saw Africa/Abidjan for a second in each of them before it turning blank. Assuming that's what I saw. It was so quick I couldn't really read it

https://github.com/user-attachments/assets/7c7967c9-d9e6-469d-b273-711a23acbce1

klgrimley commented 2 weeks ago

The Area PR chair is using an Android phone. She said her browser is Google so guessing that means Chrome. Could this be a browser engine issue?

dgershman commented 2 weeks ago

Ok cool this is helpful.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Kevin Grimley @.> Sent: Monday, August 26, 2024 9:13:31 AM To: bmlt-enabled/yap @.> Cc: Danny Gershman @.>; Comment @.> Subject: Re: [bmlt-enabled/yap] Volunteer's not scheduled if timezone missing (Issue #1121)

Brave and Safari also do not populate. I saw Africa/Abidjan for a second in each of them before it turning blank. Assuming that's what I saw. It was so quick I couldn't really read it

https://github.com/user-attachments/assets/7c7967c9-d9e6-469d-b273-711a23acbce1

— Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/1121#issuecomment-2310186850, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOD3O6G2TYMKRHFHB3TDM3ZTMSXXAVCNFSM6AAAAABM5APDKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGE4DMOBVGA. You are receiving this because you commented.Message ID: @.***>

klgrimley commented 2 weeks ago

Let me know if there's any other info I can provide

dgershman commented 2 weeks ago

Fix will be in Yap 4.4.0

dgershman commented 1 week ago

Can you give this a try? https://github.com/bmlt-enabled/yap/releases/download/4.4.0-beta1/yap-4.4.0-beta1.zip