search

bmlt-enabled / yap

Find meetings or someone to talk to over the phone leveraging a BMLT root server.
https://bmlt.app/yap
MIT License
9 stars 10 forks source link

To add option to specify different Polly settings for each language. #260

Closed californiasteve closed 5 years ago

californiasteve commented 5 years ago

To enhance user experience with different languages specified.

dgershman commented 5 years ago

@californiasteve available for testing here https://archives.bmlt.app/yap/yap-892-cc6e3ecc420e225b17756538c4ae901a613f37a1.zip

dgershman commented 5 years ago

@californiasteve have you been able to test this?

dgershman commented 5 years ago

https://yap.bmlt.app/docs/general/language-options/, see the bottom of the page

californiasteve commented 5 years ago

I can test it in the am

Steve Scranton

210.279.9199

On Sun, Apr 14, 2019 at 2:50 PM -0500, "Danny Gershman" notifications@github.com wrote:

@californiasteve available for testing here https://archives.bmlt.app/yap/yap-892-cc6e3ecc420e225b17756538c4ae901a613f37a1.zip

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

californiasteve commented 5 years ago

Works as expected. I'm wondering if we could use the spanish voice for the second part on the "press or say 1 for english, or presione o diga dos por espanol"? Right now the accent is pretty english, lol

dgershman commented 5 years ago

It should do that already. You need to specify voices for both languages, so your config should look something like.

en_US_voice = "Polly.Kendra" es_US_voice = "Polly.Penelope" language_selections "en-US,es-US"

--Danny

On Wed, Apr 17, 2019 at 10:57 AM Steve Scranton notifications@github.com wrote:

Works as expected. I'm wondering if we could use the spanish voice for the second part on the "press or say 1 for english, or presione o diga dos por espanol"? Right now the accent is pretty english, lol

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/yap/issues/260#issuecomment-484126240, or mute the thread https://github.com/notifications/unsubscribe-auth/ABw9u2-nqDVzoJ8FcMcEUMGqhJccupk6ks5vhzZGgaJpZM4cV4eI .

dgershman commented 5 years ago

Ignore my syntax errors, you get the point hopefully.

On Wed, Apr 17, 2019 at 11:02 AM Danny Gershman danny.gershman@gmail.com wrote:

It should do that already. You need to specify voices for both languages, so your config should look something like.

en_US_voice = "Polly.Kendra" es_US_voice = "Polly.Penelope" language_selections "en-US,es-US"

--Danny

On Wed, Apr 17, 2019 at 10:57 AM Steve Scranton notifications@github.com wrote:

Works as expected. I'm wondering if we could use the spanish voice for the second part on the "press or say 1 for english, or presione o diga dos por espanol"? Right now the accent is pretty english, lol

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/yap/issues/260#issuecomment-484126240, or mute the thread https://github.com/notifications/unsubscribe-auth/ABw9u2-nqDVzoJ8FcMcEUMGqhJccupk6ks5vhzZGgaJpZM4cV4eI .

californiasteve commented 5 years ago

Got it, testing now.

On 4/17/2019 10:03 AM, Danny Gershman wrote:

Ignore my syntax errors, you get the point hopefully.

On Wed, Apr 17, 2019 at 11:02 AM Danny Gershman danny.gershman@gmail.com wrote:

It should do that already. You need to specify voices for both languages, so your config should look something like.

en_US_voice = "Polly.Kendra" es_US_voice = "Polly.Penelope" language_selections "en-US,es-US"

--Danny

On Wed, Apr 17, 2019 at 10:57 AM Steve Scranton notifications@github.com wrote:

Works as expected. I'm wondering if we could use the spanish voice for the second part on the "press or say 1 for english, or presione o diga dos por espanol"? Right now the accent is pretty english, lol

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

https://github.com/bmlt-enabled/yap/issues/260#issuecomment-484126240, or mute the thread

https://github.com/notifications/unsubscribe-auth/ABw9u2-nqDVzoJ8FcMcEUMGqhJccupk6ks5vhzZGgaJpZM4cV4eI .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/yap/issues/260#issuecomment-484128996, or mute the thread https://github.com/notifications/unsubscribe-auth/AeMeUN-HFvGtOa03UvuAvgmxidUc_8ttks5vhzfCgaJpZM4cV4eI.

dgershman commented 5 years ago

How did this work out ?

californiasteve commented 5 years ago

It works as expected once you pick a language. The first part where it asks to pick a language the Spanish prompt is still in the English voice and makes it hard to understand.

dgershman commented 5 years ago

Can you bump up to the latest build, it looks like you might be on a version prior to this change being implemented. Use the latest build 899 https://archives.bmlt.app/index.html#yap/

californiasteve commented 5 years ago

Works as expected with language-specific voices. I'll have Johnny L. test it here in a few.

californiasteve commented 5 years ago

Johnny says "totally clear now"

dgershman commented 5 years ago

Excellent, thanks for your help.

On Thu, Apr 18, 2019 at 10:38 AM Steve Scranton notifications@github.com wrote:

Johnny says "totally clear now"

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/yap/issues/260#issuecomment-484537730, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOD3O7KAPDENQJJGDGCEO3PRCBUPANCNFSM4HCXQ6EA .

dgershman commented 5 years ago

released in yap 3.1.0