search

bmlt-enabled / yap

Find meetings or someone to talk to over the phone leveraging a BMLT root server.
https://bmlt.app/yap
MIT License
9 stars 10 forks source link

Australian Postcodes often failing to return search results or return incorrect results #510

Closed brustar64 closed 3 years ago

brustar64 commented 3 years ago

Describe the bug There are many Australian post codes which fail. EG 2010 (Darlinghurst fails on Twilio but if we search on crouton it lands us in Kansas), 2015 Surrey Hills (fails on yap but sends us to Junction Hill in the USA on Crouton) 5000 (Adelaide - returns Sydney meetings), 3000 Melbourne (errors out), 3005 Docklands Melbourne (error's out) there are many others that don't work correctly. There are also many that do work correctly. I have

What version are you running? 3.9.9

Did this happen on prior versions to the one you are running? It did but its really quite bad now with many post codes failing throughout Australia. The post codes work if you add the state abbreviation after the postcode.

To Reproduce Steps to reproduce the behavior: Send 5000 (Adelaide) to our Twilio number and it returns Sydney meetings (600 klms away)

Expected behavior Australian postcodes return results that correspond to the actual postcodes we enter.

dgershman commented 3 years ago

I thought that you disabled postcodes due to their unreliability with the google maps API?

dgershman commented 3 years ago

ref: https://github.com/bmlt-enabled/yap/issues/231

brustar64 commented 3 years ago

We disabled them on the phone line but there's been a whole bunch of NA business cards and posters and TV CSA's produced that say enter your postcode. 🙁

From: Danny Gershman notifications@github.com Sent: Sunday, 14 February 2021 1:21 AM To: bmlt-enabled/yap yap@noreply.github.com Cc: brustar64 brustar64@hotmail.com; Author author@noreply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

I thought that you disabled postcodes due to their unreliability with the google maps API?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/510#issuecomment-778633277, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG5KHLZ3GS27WQONNHTUZSLS62KHHANCNFSM4XR3FWRA.

dgershman commented 3 years ago

We determined that the Google Maps API was unreliable. I'm sorry there isn't anything I can do about that.

On Sat, Feb 13, 2021 at 3:13 PM brustar64 notifications@github.com wrote:

We disabled them on the phone line but there's been a whole bunch of NA business cards and posters and TV CSA's produced that say enter your postcode. 🙁

From: Danny Gershman notifications@github.com Sent: Sunday, 14 February 2021 1:21 AM To: bmlt-enabled/yap yap@noreply.github.com Cc: brustar64 brustar64@hotmail.com; Author author@noreply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

I thought that you disabled postcodes due to their unreliability with the google maps API?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/bmlt-enabled/yap/issues/510#issuecomment-778633277>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AG5KHLZ3GS27WQONNHTUZSLS62KHHANCNFSM4XR3FWRA>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/yap/issues/510#issuecomment-778671926, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOD3O7G7S6NI2EKO2URPSTS63MNVANCNFSM4XR3FWRA .

dgershman commented 3 years ago

https://aceik.com.au/2018/09/25/geocoding-australian-postcodes/

dgershman commented 3 years ago

If you want to do some research you are more than welcome.

http://maps.google.com/maps/api/geocode/json?components=country:AU%7Cpostal_code:2340&sensor=false&api_key=

brustar64 commented 3 years ago

I'm actually in the process of trying to verify the ownership of our site with a TXT record from the Google Developer Console added to DNS - we recently migrated our domain registrar but the DNS doesn't allow me to add TXT (or any other records). I've logged a support call for that.

From: Danny Gershman notifications@github.com Sent: Sunday, 14 February 2021 6:46 AM To: bmlt-enabled/yap yap@noreply.github.com Cc: brustar64 brustar64@hotmail.com; Author author@noreply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

If you want to do some research you are more than welcome.

http://maps.google.com/maps/api/geocode/json?components=country:AU%7Cpostal_code:2340&sensor=false&api_key=

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/510#issuecomment-778675913, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG5KHLZAQTJPAII2ERYTSMLS63QJNANCNFSM4XR3FWRA.

brustar64 commented 3 years ago

When we search for the failing postcodes on Crouton searchable map it returns a URL which produces the following message

({"meetings":{},"formats":[]});

From: Bruce Gardner brustar64@hotmail.com Sent: Sunday, 14 February 2021 6:51 AM To: bmlt-enabled/yap reply@reply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

I'm actually in the process of trying to verify the ownership of our site with a TXT record from the Google Developer Console added to DNS - we recently migrated our domain registrar but the DNS doesn't allow me to add TXT (or any other records). I've logged a support call for that.

From: Danny Gershman notifications@github.com Sent: Sunday, 14 February 2021 6:46 AM To: bmlt-enabled/yap yap@noreply.github.com Cc: brustar64 brustar64@hotmail.com; Author author@noreply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

If you want to do some research you are more than welcome.

http://maps.google.com/maps/api/geocode/json?components=country:AU%7Cpostal_code:2340&sensor=false&api_key=

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/510#issuecomment-778675913, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG5KHLZAQTJPAII2ERYTSMLS63QJNANCNFSM4XR3FWRA.

brustar64 commented 3 years ago

How would we add a PostcodToState lookup for Australia or alteratively make a call to the Australia post API instead of Google? This would probably require a forked development of the BMLT/Crouton/YAP for Australia right?

I think it would make more sense do a reprint of posters/business cards (other published information) to tell people to use postcode + State/Territory...

From: Bruce Gardner brustar64@hotmail.com Sent: Sunday, 14 February 2021 6:53 AM To: bmlt-enabled/yap reply@reply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

When we search for the failing postcodes on Crouton searchable map it returns a URL which produces the following message

({"meetings":{},"formats":[]});

From: Bruce Gardner brustar64@hotmail.com Sent: Sunday, 14 February 2021 6:51 AM To: bmlt-enabled/yap reply@reply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

I'm actually in the process of trying to verify the ownership of our site with a TXT record from the Google Developer Console added to DNS - we recently migrated our domain registrar but the DNS doesn't allow me to add TXT (or any other records). I've logged a support call for that.

From: Danny Gershman notifications@github.com Sent: Sunday, 14 February 2021 6:46 AM To: bmlt-enabled/yap yap@noreply.github.com Cc: brustar64 brustar64@hotmail.com; Author author@noreply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

If you want to do some research you are more than welcome.

http://maps.google.com/maps/api/geocode/json?components=country:AU%7Cpostal_code:2340&sensor=false&api_key=

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/510#issuecomment-778675913, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG5KHLZAQTJPAII2ERYTSMLS63QJNANCNFSM4XR3FWRA.

brustar64 commented 3 years ago

FYI here's the Australia Post API https://auspost.com.au/developers/docs/api/locations/overview

From: Bruce Gardner brustar64@hotmail.com Sent: Sunday, 14 February 2021 7:14 AM To: bmlt-enabled/yap reply@reply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

How would we add a PostcodToState lookup for Australia or alteratively make a call to the Australia post API instead of Google? This would probably require a forked development of the BMLT/Crouton/YAP for Australia right?

I think it would make more sense do a reprint of posters/business cards (other published information) to tell people to use postcode + State/Territory...

From: Bruce Gardner brustar64@hotmail.com Sent: Sunday, 14 February 2021 6:53 AM To: bmlt-enabled/yap reply@reply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

When we search for the failing postcodes on Crouton searchable map it returns a URL which produces the following message

({"meetings":{},"formats":[]});

From: Bruce Gardner brustar64@hotmail.com Sent: Sunday, 14 February 2021 6:51 AM To: bmlt-enabled/yap reply@reply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

I'm actually in the process of trying to verify the ownership of our site with a TXT record from the Google Developer Console added to DNS - we recently migrated our domain registrar but the DNS doesn't allow me to add TXT (or any other records). I've logged a support call for that.

From: Danny Gershman notifications@github.com Sent: Sunday, 14 February 2021 6:46 AM To: bmlt-enabled/yap yap@noreply.github.com Cc: brustar64 brustar64@hotmail.com; Author author@noreply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

If you want to do some research you are more than welcome.

http://maps.google.com/maps/api/geocode/json?components=country:AU%7Cpostal_code:2340&sensor=false&api_key=

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/510#issuecomment-778675913, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG5KHLZAQTJPAII2ERYTSMLS63QJNANCNFSM4XR3FWRA.

dgershman commented 3 years ago

This is super low priority for me, I would suggest that you work out alternative plans given that you were already aware of the shortcomings of the Google Maps API for Australia with Postal Codes.

On Sat, Feb 13, 2021 at 4:16 PM brustar64 notifications@github.com wrote:

FYI here's the Australia Post API https://auspost.com.au/developers/docs/api/locations/overview

From: Bruce Gardner brustar64@hotmail.com Sent: Sunday, 14 February 2021 7:14 AM To: bmlt-enabled/yap reply@reply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

How would we add a PostcodToState lookup for Australia or alteratively make a call to the Australia post API instead of Google? This would probably require a forked development of the BMLT/Crouton/YAP for Australia right?

I think it would make more sense do a reprint of posters/business cards (other published information) to tell people to use postcode + State/Territory...

From: Bruce Gardner brustar64@hotmail.com Sent: Sunday, 14 February 2021 6:53 AM To: bmlt-enabled/yap reply@reply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

When we search for the failing postcodes on Crouton searchable map it returns a URL which produces the following message

({"meetings":{},"formats":[]});

From: Bruce Gardner brustar64@hotmail.com Sent: Sunday, 14 February 2021 6:51 AM To: bmlt-enabled/yap reply@reply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

I'm actually in the process of trying to verify the ownership of our site with a TXT record from the Google Developer Console added to DNS - we recently migrated our domain registrar but the DNS doesn't allow me to add TXT (or any other records). I've logged a support call for that.

From: Danny Gershman notifications@github.com Sent: Sunday, 14 February 2021 6:46 AM To: bmlt-enabled/yap yap@noreply.github.com Cc: brustar64 brustar64@hotmail.com; Author author@noreply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

If you want to do some research you are more than welcome.

http://maps.google.com/maps/api/geocode/json?components=country:AU%7Cpostal_code:2340&sensor=false&api_key=

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/bmlt-enabled/yap/issues/510#issuecomment-778675913>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AG5KHLZAQTJPAII2ERYTSMLS63QJNANCNFSM4XR3FWRA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/yap/issues/510#issuecomment-778679358, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOD3OZ4TRXB2USF4PK53MLS63TZ5ANCNFSM4XR3FWRA .

brustar64 commented 3 years ago

I can't use http://maps.google.com/maps/api/geocode/json?components=country:AU%7Cpostal_code:2340&sensor=false&api_key= with our API key because its restricted 🙁

From: Danny Gershman notifications@github.com Sent: Sunday, 14 February 2021 6:46 AM To: bmlt-enabled/yap yap@noreply.github.com Cc: brustar64 brustar64@hotmail.com; Author author@noreply.github.com Subject: Re: [bmlt-enabled/yap] Australian Postcodes often failing to return search results or return incorrect results (#510)

If you want to do some research you are more than welcome.

http://maps.google.com/maps/api/geocode/json?components=country:AU%7Cpostal_code:2340&sensor=false&api_key=

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/510#issuecomment-778675913, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG5KHLZAQTJPAII2ERYTSMLS63QJNANCNFSM4XR3FWRA.

dgershman commented 3 years ago

You should be able to generate a new API key temporarily w/o restrictions (do not share it).

dgershman commented 3 years ago

Per prior discovery, there is no ability for us to make the Google Maps API better. We had determined that using Postal Codes for Austrailia was inaccurate and we had a shared understanding that you should disable the feature.

dgershman commented 3 years ago

If you do further research and find some better way to use the API, we could consider making changes to support that.