search

bmlt-enabled / yap

Find meetings or someone to talk to over the phone leveraging a BMLT root server.
https://bmlt.app/yap
MIT License
9 stars 10 forks source link

blasting then voicemail doesn't work if there is an invalid or disconnected number among the volunteers #971

Closed alanb2718 closed 4 months ago

alanb2718 commented 6 months ago

Describe the bug (or maybe it's an enhancement??) If one of the volunteers has a disconnected number, blasting then voicemail never goes to voicemail -- it just keeps ringing.

What version are you running? 4.3.1-beta1

Did this happen on prior versions to the one you are running? Yes, something like this happened also with 4.2.11.

To Reproduce Steps to reproduce the behavior:

  1. Set up yap for blasting then voicemail.
  2. Add a disconnected or otherwise bad number to the volunteers list. (To reproduce, I used a recently released Twilio number.)
  3. Call the helpline and ask to talk with a volunteer.

Expected behavior If one of the numbers is bad, I would expect yap in blast mode to still go to voicemail after the timeout. Ideally there would be a report also regarding the bad number.

Additional context The Twilio log for the test helpline number says that the released number was busy; there wasn't an error otherwise. I encountered something similar when trying to bring a new area on to yap. It turns out the helpline coordinator just copied over the numbers from their old installation but didn't test them. One of those numbers was bad -- not sure how since I didn't try to debug carefully at the time -- but that one gave an error on the Twilio log (which is how we discovered the problem). Same thing happened -- calls just kept ringing and never went to voicemail.

dgershman commented 6 months ago

I was able to reproduce this. This is an old bug and it deserves to be fixed!

dgershman commented 4 months ago

The same issue occurs for any call strategy and anytime you use a number that doesn't exist.

dgershman commented 4 months ago

fix coming in 4.3.4

dgershman commented 4 months ago

Screenshot 2024-05-04 at 5 11 28 PM Screenshot 2024-05-04 at 5 11 15 PM

alanb2718 commented 4 months ago

I tried the fix in 4.3.4-beta1, and alas it's still hanging and not sending the call to voicemail when there is a bad number -- at least of a particular kind -- in the volunteer list. (The number that causes this problem is a Twilio number that we returned to the pool.) I'll send you a screenshot similar to the one above, and the laravel log, as a DM. (It's got my own number in it as well so I won't put it here.)

Then I tried it with the bad number in the screenshot above (212-555-5555) and it did send the call to voicemail.

dgershman commented 4 months ago

Ok I’ll test this other use case.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Alan B @.> Sent: Saturday, May 4, 2024 7:40:31 PM To: bmlt-enabled/yap @.> Cc: Danny Gershman @.>; Assign @.> Subject: Re: [bmlt-enabled/yap] blasting then voicemail doesn't work if there is an invalid or disconnected number among the volunteers (Issue #971)

I tried the fix in 4.3.4-beta1, and alas it's still hanging and not sending the call to voicemail when there is a bad number -- at least of a particular kind -- in the volunteer list. (The number that causes this problem is a Twilio number that we returned to the pool.) I'll send you a screenshot similar to the one above, and the laravel log, as a DM. (It's got my own number in it as well so I won't put it here.)

Then I tried it with the bad number in the screenshot above (212-555-5555) and it did send the call to voicemail.

— Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/971#issuecomment-2094502534, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOD3O22EKNFL52A3C7KZ5TZAVWW7AVCNFSM6AAAAABE4OF3O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGUYDENJTGQ. You are receiving this because you were assigned.Message ID: @.***>

dgershman commented 4 months ago

figured out what the difference is. these released numbers return a busy signal, not a failure.

dgershman commented 4 months ago

working on a fix now.

dgershman commented 4 months ago

Try with 4.3.4-beta2

alanb2718 commented 4 months ago

Working for both numbers now (the one that fails and the one that gives a busy signal). One thing I did not test is having a volunteer who never answers and who does not have voicemail -- I don't have a number handy with that behavior. Is that already known to work?

dgershman commented 4 months ago

If they don't press 1 after answering it will result in a timeout.

alanb2718 commented 4 months ago

What happens if they never answer? (Landlines used to be that way -- maybe a few still are.)

dgershman commented 4 months ago

It times out after whatever the setting is.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Alan B @.> Sent: Saturday, May 4, 2024 11:11:45 PM To: bmlt-enabled/yap @.> Cc: Danny Gershman @.>; Assign @.> Subject: Re: [bmlt-enabled/yap] blasting then voicemail doesn't work if there is an invalid or disconnected number among the volunteers (Issue #971)

What happens if they never answer?

— Reply to this email directly, view it on GitHubhttps://github.com/bmlt-enabled/yap/issues/971#issuecomment-2094564530, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOD3O6ZO62EWZY5YKB6ZTLZAWPPDAVCNFSM6AAAAABE4OF3O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGU3DINJTGA. You are receiving this because you were assigned.Message ID: @.***>