fix for adding application to update set

bmoers / sn-cicd-integration

Server Component for CICD

https://github.com/bmoers/sn-cicd/tree/release/4

8 stars 37 forks source link

fix for adding application to update set #17

Closed g-matharu closed 4 years ago

g-matharu commented 4 years ago

Only Custom applications (scoped/globally scoped) are added to the update set.

bmoers commented 4 years ago

Think it would be better to move the query to the app up to "sys_scope" instead of "sys_app". If "Global/global" don't add the App to the US as Global is available In all other cases get the app from sys_scope instead

Guess it would also be better to move the u_repository field up to sys_scope... Thoughts?

bmoers commented 4 years ago

As discussed, PR fine as it only makes sense to add custom scoped apps to the US. Global by default, plugins & store apps require manual installation first