Fixes #78: Links and parentheses don't work well together

bmoliveira / MarkdownKit

A simple and customizable Markdown Parser for Swift

MIT License

783 stars 136 forks source link

Fixes #78: Links and parentheses don't work well together #79

Closed AndreasVerhoeven closed 3 years ago

AndreasVerhoeven commented 3 years ago

Summary:

we count the number of opening and closing parentheses in the link
if we have more closing parentheses than opening parentheses
AND if there are closing parentheses at the end of the link, we assume they should originally have been outside of the link and be part of the regular text

This seems to work well in practice: Almost all links with parentheses have them balanced (e.g. wikipedia links), and links surrounded by () now work correctly as well

gaebel commented 3 years ago

Thank you for your contribution :) I'm closing this pr in favour of #90, which contains your commits and some small tweaks from my side.