search

bmoliveira / Moya-ObjectMapper

ObjectMapper bindings for Moya and RxSwift
MIT License
492 stars 171 forks source link

ObjectMapper version is limited to 2.x #71

Open letko-dmitry opened 6 years ago

letko-dmitry commented 6 years ago

Right now the version of ObjectMapper is specified as ss.dependency "ObjectMapper", '~> 2.2' in podspec. And it doesn't allow us to use version 3.0 of the library. But it's definitely compatible. So I'd propose to make dependency softer. Not sure if it's needed to make PR for that.

dylanmaryk commented 6 years ago

Just created a PR for this: #72

rayjun83 commented 6 years ago

maybe now should be ss.dependency "ObjectMapper", '~> 3.1.0'

dylanmaryk commented 6 years ago

@rayjun83 Created PR #76 for this

ffleandro commented 5 years ago

When will this be merged?

dylanmaryk commented 5 years ago

@ffleandro there's no need now, as the version has already been bumped higher