search

bmorelli25 / interactive-bitcoin-price-chart

Interactive Bitcoin Price Chart - built with React
MIT License
169 stars 58 forks source link

Fix for chart not showing in Firefox #4

Closed alxwrd closed 6 years ago

alxwrd commented 6 years ago

This addresses issue #3.

The problem was Firefox does not handle commas (,) in an SVG path. See https://stackoverflow.com/questions/12661323/svg-path-tag-does-not-work-on-firefox.

This was occuring in makePath() and makeArea() when the string pathD was concatenated to the array result of data.map.

I've added a .join("") onto the end of result to .map() to turn it back into a string.

Before

image

After

image

After in Chrome

image

jmsv commented 6 years ago

Looks good :+1:

bmorelli25 commented 6 years ago

Awesome! Thanks @jamesevickery for pointing this out and @alxwrd for the fix!