bmoren / p5.collide2D

A collision detection library for 2D geometry in p5.js
Other
582 stars 296 forks source link

[added] readme section " How to use CDN links" #36

Closed wisehackermonkey closed 4 years ago

wisehackermonkey commented 4 years ago

additionally example of where to add it within the html to to get your sketch to work

bmoren commented 4 years ago

I think this is overly complex. I think we could get away with something simpler like:

To include the library via a CDN, add the library's CDN link using a script tag inside the index.html file within your project. Add the tag below the core p5.js script tag:

<!--
This enables the p5.js core library, it is automatically added within the p5.js web editor.
You'll need to include the core p5.js before using p5.collide2D. 
-->
<script src="https://cdnjs.cloudflare.com/ajax/libs/p5.js/0.10.2/p5.js"></script>

<!--include p5.collide2D addon library-->
<script src="https://unpkg.com/p5.collide2d"></script> 

This would provide enough for beginners to get up and running and enough info with the list for intermediate users to have the info they need readily accessible. I dont think we need to provide all the CDN options in the example, and it's just overwhelming to know which to choose. with this, unpkg will just use the latest version of the library which is likely fine for any beginner.

wisehackermonkey commented 4 years ago

Sounds good

I like the simpler version its more clear.

Question:

Should I close the pull request and open a new one with the simpler version?

bmoren commented 4 years ago

that works for me! thank you!

On Wed, Jul 1, 2020 at 8:00 PM Oran C notifications@github.com wrote:

Sounds good I like the simpler version its more clear. Question: Should I close the pull request and open a new one with the simpler version?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bmoren/p5.collide2D/pull/36#issuecomment-652718664, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKSMDHKGZ3YZEKKQWYZ6L3RZPLZNANCNFSM4OLYWRYQ .

--

Ben Moren He/Him/His http://benmoren.com

wisehackermonkey commented 4 years ago

Done #39