search

bmoren / p5js-snippets

p5js snippets for atom.io
GNU General Public License v3.0
23 stars 5 forks source link

Possible fix for issue #12 #18

Closed tobias-wilfert closed 3 years ago

tobias-wilfert commented 3 years ago

What was the issue?

When building the snippets the descriptionMoreURL had a hardcoded prefix http://p5js.org/reference/#/p5/ which caused some links to be invalid.

For example: https://p5js.org/reference/#/p5/setType was generated when actually the link should be https://p5js.org/reference/#/p5.Noise/setType

As far as I could determine it should be the value of the class field provided in the json. This value is indeed p5 for many elements but not for all.

What did I change?

I changed the prefix used to generate the descriptionMoreURL so that it uses the value of the class rather then p5

Hope this solves #12 and I didn't break anything.

bmoren commented 3 years ago

thanks you! I'm going to merge this and let me know if you run into any other issues! Good to get it up to date too!