search

bmoren / p5js-toolbar

p5js toolbar for atom.io with a run button to launch a local server and quick links to common resources
9 stars 5 forks source link

update p5 to latest version? #10

Closed mikima closed 5 years ago

mikima commented 5 years ago

I see that in #8 you're planning to update automatically to the latest version, but do you think is possible for now to release a new version of the toolbar using the latest version of p5.js (0.9)? I use your plug-in in a course and i think is really effective. If you want I can update the code and send a pull request. Let me know, thank you for the great work.

bmoren commented 5 years ago

Hi Mikima,

I'd like to do this, but I'm unable to get to it this week due to a dead laptop in the shop. My plan was to do what the p5 web editor has done and switch to a link to the CDN for the current version, although I understand this presents issues for offline coding. The rationale was to find a 'latest' resource so that the toolbar would have to be updated very sparingly. Best I can find is here: https://p5js.org/assets/js/p5.min.js

let me know what you think about this!

On Tue, Sep 17, 2019 at 10:08 AM mikima notifications@github.com wrote:

I see that in #8 https://github.com/bmoren/p5js-toolbar/issues/8 you're planning to update automatically to the latest version, but do you think is possible for now to release a new version of the toolbar using the latest version of p5.js (0.9)? I use your plug-in in a course and i think is really effective. If you want I can update the code and send a pull request. Let me know, thank you for the great work.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bmoren/p5js-toolbar/issues/10?email_source=notifications&email_token=AAKSMDDIYJ3EBRQETZODQDLQKDXHJA5CNFSM4IXRNHH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HL4IYZA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKSMDAX22OVAA3HZ6NZD2TQKDXHJANCNFSM4IXRNHHQ .

--

Ben Moren He/Him/His http://benmoren.com

mikima commented 5 years ago

What about downloading the latest stable version form cdnjs?

https://api.cdnjs.com/libraries?search=p5js

EDIT I just re-read your commnet#8 and is basically the same if not better the use of unpkg. Would be nice to have it downloaded rather than having it as link

bmoren commented 5 years ago

Until I can get much more time to work on this, I've update to the most current version of p5 0.9 with 0.1.9 of the toolbar.

I think the real direction to go would download the current version on the fly and store it for each use checking if there is a newer version occasionally. I know lots of folks use this for offline coding as an alternative to the web editor. so I want to make sure that that functionality persists.

mikima commented 5 years ago

Thanks!

mikima commented 5 years ago

Hello @bmoren, sorry to bother you again, but also p5.dom and p5.sound are outdated.

Now, p5.dom.js is part of p5.js so you don't need it. p5.sound.js went thorught a major revision and the one included in the toolbar is no more working.

If you want i can pr a repo with the new ones.

Best!

bmoren commented 5 years ago

done!