search

bmorris3 / kelp

Photometric phase curves of exoplanets
https://kelp.readthedocs.io/en/latest/
7 stars 2 forks source link

Installation with Python>3.9 #43

Open odemangeon opened 8 months ago

odemangeon commented 8 months ago

Hi Brett,

I was trying to (re-)install kelp. As you probably know, I have installed it before. I ran into an issue because this time, I tried to install it in an environment that uses Python 3.11. During the pip install it kept wanting to install cython=0.29.14 which is producing an error since the code of this cython version tries to import Iterable from collections which is no longer possible in recent python versions. I banged my head against the wall for some time because looking at the master branch there was no specific version of cython in your requirements (pyproject.toml). THis was until I realize that the pip version (0.5.0) actually have different requirements and indeed imposes cython=0.29.14. Is this requirement really necessary for version 0.5.0 ? If yes, could you make a new pip release of the 0.5.1 version of kelp soon ? If no, I will degrade my python version.

All the best, Olivier.

bmorris3 commented 8 months ago

Hi Olivier,

Thanks for reaching out before you banged your head against the wall any further 😄. I'm testing some fixes in #44.

bmorris3 commented 8 months ago

Ok, tests are passing on #44. It looks one issue could be that you referred to changes on master, but now the primary branch is the main branch – could that be part of the problem?

(This issue was automatically closed by merging #44, I've reopened it to continue discussion until things work for you, of course.)