search

bmorris3 / shone

Radiative transfer in JAX
https://shone.readthedocs.io/
MIT License
4 stars 5 forks source link

add charge to species_name_to_fastchem_name #13

Closed bprinoth closed 4 months ago

bprinoth commented 4 months ago

This solves issue #12 by adding the charge to atoms where charge is bigger or smaller than 0. I included the case for negatively charged ions, not sure if it ever will be used, but we have it now anyways.

Here is how the call has to be adopted in PR #11's example:


    species_name_to_fastchem_name(name, charge)
for name, charge in zip(available_species.iloc[species_indices ['name'], available_species.iloc[species_indices]['charge'])]
bprinoth commented 4 months ago

Looks good! I applied them all :)