bmorris3 / shone

Radiative transfer in JAX
https://shone.readthedocs.io/
MIT License
4 stars 5 forks source link

Add basic convolution kernels and methods #16

Open bmorris3 opened 4 months ago

bmorris3 commented 4 months ago

To do:

codecov[bot] commented 4 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

bprinoth commented 4 months ago

@Hoeijmakers I am trying to test these two kernels by reproducing what tayph.operations.blur_rotate does (which I think should be doing the same if both of these rotations are applied after each other).

Tayph produces these cute little wings, looks a bit like batman, but the combination of Gauss and then rot kernel does not. Any idea what I am missing?

Screenshot 2024-06-04 at 14 46 42

Hoeijmakers commented 4 months ago

I think that you have all that's necessary to figure out the difference ;)

bprinoth commented 4 months ago

@Hoeijmakers You were indeed right about that ;)