search

bmorris3 / tynt

Color filter approximations in Python
https://tynt.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Make the Filter class be a "generator" of filter classes #5

Closed eteq closed 5 years ago

eteq commented 5 years ago

This is related to #1 but subtly different (since #1 is one of a few possible solutions):

The current Filter object is not really a filter, but rather a generator for filter "results". I think a more natural thing to do would be something like: Filter->FilterGenerator reconstruct-> returns an ApproximatedFilter object (a la #1) download_true_transmittance -> returns a LookupTableFilter object (or following #1 could be the existing tabular model)

Then it's clearer that the main class is actually just a tool to generate filters, which are the things the user actually then works with to do anything.

bmorris3 commented 5 years ago

Done!