bmorris3 / tynt

Color filter approximations in Python
https://tynt.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Include code to generate the reconstructions in the package #6

Closed eteq closed 5 years ago

eteq commented 5 years ago

Right now the reconstruction is in notebooks, which makes sense since that was the starting point. But eventually it would be good for the reconstruction code to live in the repo itself. Could be done with #1, since that's basically a "fitting" process (although that might be overkill).

And related to that there should be a test that first downloads the "true" model, generates the reconstruction, and compares that to the saved reconstruction to show that the whole thing round-trips.

bmorris3 commented 5 years ago

The code for Fourier decomposition is now squished into a few methods on the FilterGenerator object, and a brief tutorial on how to use them sits in this repurposed notebook.

Still to do: add docstrings on the methods, add brief tutorial in the narrative docs.

bmorris3 commented 5 years ago

Code now included with docstrings and examples.